stack: fix phasecache._phasesets check logic When _phasesets is not None, it's a list, and it contains set()s of revisions in a specific phase, starting from public, draft, secret and so on. But since repos are supposed to have the majority of revisions in public phase, the first element of this list is not a (potentially huge) set, but None. Previously this code tried to check if there's any element that is None, and was always finding None at index 0, so the short path was executed every time and the rest of the function was never used.

     1

#require test-repo

     2

     3

  $ checkflake8() {

     4

  >   if ! (which flake8 > /dev/null); then

     5

  >     echo skipped: missing tool: flake8;

     6

  >     exit 80;

     7

  >   fi;

     8

  > };

     9

  $ checkflake8

    10

    11

Copied from Mercurial core (60ee2593a270)

    12

    13

  $ cd "`dirname "$TESTDIR"`"

    14

    15

run flake8 if it exists; if it doesn't, then just skip

    16

    17

  $ hg files -0 'set:(**.py or grep("^#!.*python")) - removed()' \

    18

  > -X hgext3rd/evolve/thirdparty \

    19

  > 2>/dev/null \

    20

  > | xargs -0 flake8