evolve: use merge.update() for resolving phase divergence Iterating over the manifest when tree manifests and narrowness is in play produces entries for paths outside the narrowspec that represent trees. For example, if the tests/ directory of the hg repo was not in the narrowspec (and the hg repo was using tree manifests, which it doesn't), then there would be a "tests/" entry in the manifest. The merge code deals with some of these cases. For example, it's valid to do a merge if only the local side changes directories outside the narrowspec. That allows rebasing a local commit onto a public commit that had changes to the excluded paths to work. However, _resolvephasedivergent() was iterating of the manifests, which resulted in crashes for some of our users when they tried to resolve phase-divergent commits (actually content-divergent commits that became phase-divergent after the intermediate rebase). We can fix that by relying on merge.update(), since that already handles this case.

     1

#require test-repo

     2

     3

  $ checkflake8() {

     4

  >   if ! (which flake8 > /dev/null); then

     5

  >     echo skipped: missing tool: flake8;

     6

  >     exit 80;

     7

  >   fi;

     8

  > };

     9

  $ checkflake8

    10

    11

Copied from Mercurial core (60ee2593a270)

    12

    13

  $ cd "`dirname "$TESTDIR"`"

    14

    15

run flake8 if it exists; if it doesn't, then just skip

    16

    17

  $ hg files -0 'set:(**.py or grep("^#!.*python")) - removed()' \

    18

  > -X hgext3rd/evolve/thirdparty \

    19

  > 2>/dev/null \

    20

  > | xargs -0 flake8