[primary view] we should not limit related rset, else if something else than autolimited view is used, some content will be missed without a 'view all' link stable
authorSylvain Thénault <sylvain.thenault@logilab.fr>
Mon, 20 Sep 2010 15:58:45 +0200
branchstable
changeset 6291 f6cba3be6ba2
parent 6290 f68dd9dd3af2
child 6294 a1535abe6ab2
[primary view] we should not limit related rset, else if something else than autolimited view is used, some content will be missed without a 'view all' link
web/views/primary.py
--- a/web/views/primary.py	Mon Sep 20 15:50:12 2010 +0200
+++ b/web/views/primary.py	Mon Sep 20 15:58:45 2010 +0200
@@ -53,7 +53,6 @@
     def cell_call(self, row, col):
         self.cw_row = row
         self.cw_col = col
-        self.maxrelated = self._cw.property_value('navigation.related-limit')
         entity = self.cw_rset.complete_entity(row, col)
         self.render_entity(entity)
 
@@ -246,11 +245,7 @@
 
     def _relation_rset(self, entity, rschema, role, dispctrl):
         try:
-            dispctrl.setdefault('limit', self.maxrelated)
-            limit = dispctrl['limit']
-            if limit is not None:
-                limit += 1
-            rset = entity.related(rschema.type, role, limit=limit)
+            rset = entity.related(rschema.type, role)
         except Unauthorized:
             return
         if 'filter' in dispctrl:
@@ -303,7 +298,10 @@
 
     def call(self, **kwargs):
         if 'dispctrl' in self.cw_extra_kwargs:
-            limit = self.cw_extra_kwargs['dispctrl'].get('limit')
+            if 'limit' in self.cw_extra_kwargs['dispctrl']:
+                limit = self.cw_extra_kwargs['dispctrl']['limit']
+            else:
+                limit = self._cw.property_value('navigation.related-limit')
             list_limit = self.cw_extra_kwargs['dispctrl'].get('use_list_limit', 5)
             subvid = self.cw_extra_kwargs['dispctrl'].get('subvid', 'incontext')
         else: