Mercurial Mercurial > pub > hg > cubicweb / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
[tableviews] use ``select_or_none`` instead of ``try: select() except:``
authorPierre-Yves David <pierre-yves.david@logilab.fr>
Tue, 10 Jan 2012 16:33:27 +0100
changeset 8156 f47252e24354
parent 8155 c075950cc929
child 8158 2ee254e74382
[tableviews] use ``select_or_none`` instead of ``try: select() except:`` select_or_none is here to avoid multiplying try: except: context in the code.
web/views/tableview.py file | annotate | diff | comparison | revisions 
--- a/web/views/tableview.py	Mon Jan 09 22:40:43 2012 +0100
+++ b/web/views/tableview.py	Tue Jan 10 16:33:27 2012 +0100
@@ -458,12 +458,9 @@
     # layout callbacks #########################################################
 
     def facets_form(self, **kwargs):# XXX extracted from jqplot cube
-        try:
-            return self._cw.vreg['views'].select(
-                'facet.filtertable', self._cw, rset=self.cw_rset, view=self,
-                **kwargs)
-        except NoSelectableObject:
-            return None
+        return self._cw.vreg['views'].select_or_none(
+            'facet.filtertable', self._cw, rset=self.cw_rset, view=self,
+            **kwargs)
 
     @cachedproperty
     def domid(self):
cubicweb