add a note about modifying read only attribute stable
authorAlexandre Fayolle <alexandre.fayolle@logilab.fr>
Mon, 08 Feb 2010 13:42:22 +0100
branchstable
changeset 4503 f2b592b1d34c
parent 4500 81021d62138f
child 4505 a82af6b000f2
add a note about modifying read only attribute cf. syt's commit message in 81021d62138f
server/session.py
--- a/server/session.py	Mon Feb 08 13:33:09 2010 +0100
+++ b/server/session.py	Mon Feb 08 13:42:22 2010 +0100
@@ -475,7 +475,10 @@
                     for operation in processed:
                         operation.handle_event('revert%s_event' % trstate)
                     # res
-                    self.pending_operations[:] = processed + self.pending_operations
+
+                    # XXX self.pending_operations is supposed to be
+                    # read-only, and we are clearly modifying it here.
+                    self.pending_operations[:] = processed + self.pending_operations 
                     self.rollback(reset_pool)
                     raise
             self.pool.commit()