# HG changeset patch # User Alexandre Fayolle # Date 1265632942 -3600 # Node ID f2b592b1d34c2769316904f6e79a42ca5317b004 # Parent 81021d62138f32f443432938e7f44ab95306a628 add a note about modifying read only attribute cf. syt's commit message in 81021d62138f diff -r 81021d62138f -r f2b592b1d34c server/session.py --- a/server/session.py Mon Feb 08 13:33:09 2010 +0100 +++ b/server/session.py Mon Feb 08 13:42:22 2010 +0100 @@ -475,7 +475,10 @@ for operation in processed: operation.handle_event('revert%s_event' % trstate) # res - self.pending_operations[:] = processed + self.pending_operations + + # XXX self.pending_operations is supposed to be + # read-only, and we are clearly modifying it here. + self.pending_operations[:] = processed + self.pending_operations self.rollback(reset_pool) raise self.pool.commit()