don't call complete here, it may fail in case of missing relation stable
authorSylvain Thénault <sylvain.thenault@logilab.fr>
Wed, 07 Oct 2009 15:11:55 +0200
branchstable
changeset 3599 e64574673827
parent 3598 b4a2bad9c26a
child 3600 540210e138d3
don't call complete here, it may fail in case of missing relation
web/views/basecontrollers.py
--- a/web/views/basecontrollers.py	Wed Oct 07 15:09:20 2009 +0200
+++ b/web/views/basecontrollers.py	Wed Oct 07 15:11:55 2009 +0200
@@ -192,8 +192,6 @@
     except ValidationError, ex:
         return (False, _validation_error(req, ex), ctrl._edited_entity)
     except Redirect, ex:
-        if ctrl._edited_entity:
-            ctrl._edited_entity.complete()
         try:
             req.cnx.commit() # ValidationError may be raise on commit
         except ValidationError, ex:
@@ -554,7 +552,6 @@
         rql = 'Any X WHERE X eid in (%s)' % (','.join(eids))
         rset = self.req.execute(rql)
         for entity in rset.entities():
-            entity.complete() # XXX really?
             yield entity
 
     @property