# HG changeset patch
# User Sylvain Thénault <sylvain.thenault@logilab.fr>
# Date 1254921115 -7200
# Node ID e6457467382762e40479d9a06a6ae62df8584295
# Parent  b4a2bad9c26adf459b04fac3bd1aebff9778fb56
don't call complete here, it may fail in case of missing relation

diff -r b4a2bad9c26a -r e64574673827 web/views/basecontrollers.py
--- a/web/views/basecontrollers.py	Wed Oct 07 15:09:20 2009 +0200
+++ b/web/views/basecontrollers.py	Wed Oct 07 15:11:55 2009 +0200
@@ -192,8 +192,6 @@
     except ValidationError, ex:
         return (False, _validation_error(req, ex), ctrl._edited_entity)
     except Redirect, ex:
-        if ctrl._edited_entity:
-            ctrl._edited_entity.complete()
         try:
             req.cnx.commit() # ValidationError may be raise on commit
         except ValidationError, ex:
@@ -554,7 +552,6 @@
         rql = 'Any X WHERE X eid in (%s)' % (','.join(eids))
         rset = self.req.execute(rql)
         for entity in rset.entities():
-            entity.complete() # XXX really?
             yield entity
 
     @property