[web test] extract a set_auth_mode method from init_authentication and use it in test_fb_login_concept to avoid bad test interaction stable
authorSylvain Thénault <sylvain.thenault@logilab.fr>
Fri, 01 Apr 2011 14:26:18 +0200
branchstable
changeset 7163 d6d905d0344f
parent 7160 923013173031
child 7165 b817d44cb606
child 7170 32b5d9d43a7e
[web test] extract a set_auth_mode method from init_authentication and use it in test_fb_login_concept to avoid bad test interaction
devtools/testlib.py
web/test/unittest_application.py
--- a/devtools/testlib.py	Fri Apr 01 01:06:41 2011 +0200
+++ b/devtools/testlib.py	Fri Apr 01 14:26:18 2011 +0200
@@ -662,13 +662,16 @@
         """
         return self.expect_redirect(lambda x: self.app_publish(x, path), req)
 
-    def init_authentication(self, authmode, anonuser=None):
+    def set_auth_mode(self, authmode, anonuser=None):
         self.set_option('auth-mode', authmode)
         self.set_option('anonymous-user', anonuser)
         if anonuser is None:
             self.config.anonymous_credential = None
         else:
             self.config.anonymous_credential = (anonuser, anonuser)
+
+    def init_authentication(self, authmode, anonuser=None):
+        self.set_auth_mode(authmode, anonuser)
         req = self.request()
         origsession = req.session
         req.session = req.cnx = None
--- a/web/test/unittest_application.py	Fri Apr 01 01:06:41 2011 +0200
+++ b/web/test/unittest_application.py	Fri Apr 01 14:26:18 2011 +0200
@@ -315,8 +315,7 @@
 
     def test_fb_login_concept(self):
         """see data/views.py"""
-        self.set_option('auth-mode', 'cookie')
-        self.set_option('anonymous-user', 'anon')
+        self.set_auth_mode('cookie', 'anon')
         self.login('anon')
         req = self.request()
         origcnx = req.cnx
@@ -325,6 +324,7 @@
         self.failIf(req.cnx is origcnx)
         self.assertEqual(req.user.login, 'turlututu')
         self.failUnless('turlututu' in page, page)
+        req.cnx.close() # avoid warning
 
     # authentication tests ####################################################