Mercurial Mercurial > pub > hg > cubicweb / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Remove a misleading comment about self.render() behavior. stable
authorChristophe de Vienne <christophe@unlish.com>
Tue, 01 Apr 2014 13:57:25 +0200
branchstable
changeset 9699 990676d3f39f
parent 9698 737983d87497
child 9700 da7d341cca76
Remove a misleading comment about self.render() behavior. The former comment suggested that View.render called with 'row' or 'col' would set cw_row or cw_col, which is not (anymore ?) accurate. Related to #3696871.
sobjects/notification.py file | annotate | diff | comparison | revisions 
--- a/sobjects/notification.py	Thu Mar 06 18:41:23 2014 +0100
+++ b/sobjects/notification.py	Tue Apr 01 13:57:25 2014 +0200
@@ -129,9 +129,10 @@
             # need a fresh stream at each iteration, reset it explicitly
             self.w = None
             try:
-                # XXX call render before subject to set .row/.col attributes on the
-                #     view
                 try:
+                    # XXX forcing the row & col here may make the content and
+                    #     subject inconsistent because subject will depend on
+                    #     self.cw_row & self.cw_col if they are set.
                     content = self.render(row=0, col=0, **kwargs)
                     subject = self.subject()
                 except SkipEmail:
cubicweb