[fti] don't catch BaseException subclasses stable
authorSylvain Thénault <sylvain.thenault@logilab.fr>
Mon, 28 Sep 2009 11:02:04 +0200
branchstable
changeset 3497 63b9541dd36f
parent 3496 35a67ac6efe8
child 3498 838ef1f527ab
[fti] don't catch BaseException subclasses
server/sources/native.py
--- a/server/sources/native.py	Mon Sep 28 11:01:32 2009 +0200
+++ b/server/sources/native.py	Mon Sep 28 11:02:04 2009 +0200
@@ -554,7 +554,7 @@
         """
         try:
             self.indexer.cursor_unindex_object(eid, session.pool['system'])
-        except:
+        except Exception: # let KeyboardInterrupt / SystemExit propagate
             if self.indexer is not None:
                 self.exception('error while unindexing %s', eid)
 
@@ -565,7 +565,7 @@
         try:
             self.indexer.cursor_reindex_object(entity.eid, entity,
                                                session.pool['system'])
-        except:
+        except Exception: # let KeyboardInterrupt / SystemExit propagate
             if self.indexer is not None:
                 self.exception('error while reindexing %s', entity)
         # update entities.mtime