[web/data] Ignore disabled widgets in cw.utils.formContents() (closes #3544492)
authorRémi Cardona <remi.cardona@logilab.fr>
Wed, 12 Feb 2014 17:32:49 +0100
changeset 9534 34d9de030564
parent 9533 fa4051e29fbe
child 9536 1e39c5e91b68
[web/data] Ignore disabled widgets in cw.utils.formContents() (closes #3544492) 17.12.1 Disabled controls : http://www.w3.org/TR/REC-html40/interact/forms.html#h-17.12.1 When set, the disabled attribute has the following effects on an element: * Disabled controls do not receive focus. * Disabled controls are skipped in tabbing navigation. * Disabled controls cannot be successful. The third one is the important one. 17.13.2 Successful controls : http://www.w3.org/TR/REC-html40/interact/forms.html#successful-controls A successful control is "valid" for submission. Every successful control has its control name paired with its current value as part of the submitted form data set. Bottom line, disable widgets should not be part of the names and values lists returned by formContents().
web/data/cubicweb.js
--- a/web/data/cubicweb.js	Fri Feb 14 15:22:56 2014 +0100
+++ b/web/data/cubicweb.js	Wed Feb 12 17:32:49 2014 +0100
@@ -222,6 +222,9 @@
         cw.utils.nodeWalkDepthFirst(elem, function (elem) {
             var name = elem.name;
             if (name && name.length) {
+                if (elem.disabled) {
+                    return null;
+                }
                 var tagName = elem.tagName.toUpperCase();
                 if (tagName === "INPUT" && (elem.type == "radio" || elem.type == "checkbox") && !elem.checked) {
                     return null;