Fix sorting key for rdefs in schema viewer With changeset 234ca3cbbb46, clicking in the schema of an entity with cubicweb in py3 on "vue en boite" will probably result in an infinite spinner (which implies cw > 3.26) What happened ? This "vue en boite" used to work at least until... hg diff -c a8c1ea390400 cubicweb/schema.py @@ -993,10 +992,6 @@ class CubicWebRelationSchema(PermissionM return False return True - @deprecated('use .rdef(subjtype, objtype).role_cardinality(role)') - def cardinality(self, subjtype, objtype, target): - return self.rdef(subjtype, objtype).role_cardinality(target) - class CubicWebSchema(Schema): """set of entities and relations schema defining the possible data sets But, wait ... If I open a shell on an instance of cw 3.24 something seems off >>> list(schema['CWUniqueTogetherConstraint'].relation_definitions())[0][0].cardinality # <bound method CubicWebRelationSchema.wrapped of <constraint_of [CWUniqueTogetherConstraint,CWEType]>> We have been sorting on a method the whole time ? Is it possible what were the effects ? 1) We cannot sort function can't we ? >>> def adder(i): return lambda x: x+i >>> sorted(map(adder,range(10))) [<function __main__.<lambda>>, <function __main__.<lambda>>, ... Yes we can. 2) what does it means. >>> { adder(1) : 1 } Out[19]: {<function __main__.<lambda>>: 1} In fact the function object as a __hash__ method (which is practical for making memoizers (cache)), and return truly random results (pseudo random). My take on this patch is relations have NEVER been sorted by cardinality. No one never ever noticed. Hence, I propose to not fix a bug that never was reported.

     1

CSS Coding Standards

     2

--------------------

     3

     4

(Draft, to be continued)

     5

     6

:Naming: camelCase

     7

     8

Indentation rules

     9

~~~~~~~~~~~~~~~~~

    10

    11

- 2 spaces before properties

    12

    13

- no space before ":", one space after

    14

    15

- only one space between values of the same property

    16

    17

    18

Documentation

    19

~~~~~~~~~~~~~

    20

Please keep rules semantically linked grouped together, with a comment about

    21

what they are for.

    22

    23

Recommendation

    24

~~~~~~~~~~~~~~

    25

- Try to use existing classes rather than introduce new ones

    26

    27

- Keep things as simple as possible while in the framework

    28

    29

- Think about later customization by application

    30

    31

- Avoid introducing a new CSS file for a few lines of CSS, at least while the

    32

  framework doesn't include packing functionalities