topic: move a status message in the right scope
authorPierre-Yves David <pierre-yves.david@octobus.net>
Fri, 01 Sep 2017 17:37:47 +0200
changeset 2897 bd04a614b866
parent 2896 462adae9fea7
child 2898 3dfc88c06378
topic: move a status message in the right scope The finally get runs on failure so we should not advertise rewrite topic in the case. In addition the 'rewrote' variable can be undefined in the finally.
hgext3rd/topic/__init__.py
--- a/hgext3rd/topic/__init__.py	Wed Aug 09 11:32:19 2017 +0200
+++ b/hgext3rd/topic/__init__.py	Fri Sep 01 17:37:47 2017 +0200
@@ -388,10 +388,10 @@
             txn = repo.transaction('rewrite-topics')
             rewrote = _changetopics(ui, repo, rev, topic)
             txn.close()
+            ui.status('changed topic on %d changes\n' % rewrote)
         finally:
             lockmod.release(txn, l, wl)
             repo.invalidate()
-            ui.status('changed topic on %d changes\n' % rewrote)
         return
 
     if clear: