# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1434672491 25200
# Node ID 61849d45d47ed38473925750db34d26df1a47d63
# Parent  43dcf62237bec7a71633adf6cd725bf7c572ff10
evolve: move 'troubled()' to smarted usage

The "new" smarted can be significantly more efficient than the old was. We
convert our revset to take advantage of that.

diff -r 43dcf62237be -r 61849d45d47e hgext/evolve.py
--- a/hgext/evolve.py	Thu Jun 18 16:14:32 2015 -0700
+++ b/hgext/evolve.py	Thu Jun 18 17:08:11 2015 -0700
@@ -398,9 +398,13 @@
     Changesets with troubles.
     """
     revset.getargs(x, 0, 0, 'troubled takes no arguments')
-    return repo.revs('%ld and (unstable() + bumped() + divergent())',
-                     subset)
-
+    troubled = set()
+    troubled.update(getrevs(repo, 'unstable'))
+    troubled.update(getrevs(repo, 'bumped'))
+    troubled.update(getrevs(repo, 'divergent'))
+    troubled = revset.baseset(troubled)
+    troubled.sort() # set is non-ordered, enforce order
+    return subset & troubled
 
 ### Obsolescence graph