# HG changeset patch # User Anton Shestakov # Date 1568276570 -25200 # Node ID 13ca3810a10568bfe6d73ce5dc0395ac61fcf11b # Parent 34494a5ba69b02b44ff1335f360bf4a24173af20 stack: return from behindcount() early Reduces indentation. diff -r 34494a5ba69b -r 13ca3810a105 hgext3rd/topic/stack.py --- a/hgext3rd/topic/stack.py Thu Sep 12 14:44:19 2019 +0700 +++ b/hgext3rd/topic/stack.py Thu Sep 12 15:22:50 2019 +0700 @@ -200,21 +200,21 @@ @util.propertycache def behindcount(self): + if not self._revs: + return 0 deps, rdeps = self._dependencies - if self._revs: - minroot = [min(r for r in self._revs if not deps[r])] - try: - dest = destutil.destmerge(self._repo, action=b'rebase', - sourceset=minroot, - onheadcheck=False) - return len(self._repo.revs(b"only(%d, %ld)", dest, minroot)) - except error.NoMergeDestAbort: - return 0 - except error.ManyMergeDestAbort as exc: - # XXX we should make it easier for upstream to provide the information - self.behinderror = pycompat.bytestr(exc).split(b'-', 1)[0].rstrip() - return -1 - return 0 + minroot = [min(r for r in self._revs if not deps[r])] + try: + dest = destutil.destmerge(self._repo, action=b'rebase', + sourceset=minroot, + onheadcheck=False) + return len(self._repo.revs(b"only(%d, %ld)", dest, minroot)) + except error.NoMergeDestAbort: + return 0 + except error.ManyMergeDestAbort as exc: + # XXX we should make it easier for upstream to provide the information + self.behinderror = pycompat.bytestr(exc).split(b'-', 1)[0].rstrip() + return -1 @util.propertycache def branches(self):