stack: make a deep copy of `dependencies` before modifying its items
The algorithm later on in this method uses .remove() to remove individual
elements from items in dependencies, which before this patch modified the
cached property contents. So for further use that dictionary was in the form of
{1: set([])}, i.e. all sets were empty.
This deep copy block could be way simpler, but the problem is that sometimes we
get lists of _succs() from evolvebits.builddependencies(). Note: this happens
only in topic's stack version of builddependencies() and it looks like a
suboptimal way to handle multiple successors (see evolve's counterpart
function).
stack.builddependencies method is removed, it has served its purpose (see the
previous patch).
Test for issue 5881 present at https://bz.mercurial-scm.org/show_bug.cgi?id=5881
===============================================================================
which is about that if the working copy parent is obsolete then evolve update
to its successor revision and stop; it doesn't continue to evolve remaining
revisions those were suppossed to evovle.
Setup
=====
$ cat >> $HGRCPATH <<EOF
> [phases]
> publish = False
> [alias]
> glog = log -GT "{rev}:{node|short} {desc}\n ({bookmarks}) {phase}"
> [extensions]
> EOF
$ echo "evolve=$(echo $(dirname $TESTDIR))/hgext3rd/evolve/" >> $HGRCPATH
$ hg init issue5881
$ cd issue5881
Prepare the directory by creating an orphan and update to its obsolete parent:
$ for ch in a b c; do echo $ch > $ch; hg ci -Am "added "$ch; done;
adding a
adding b
adding c
$ hg up 1 -q
$ hg ci --amend -m "updated b"
1 new orphan changesets
$ hg up 1
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
working directory parent is obsolete! (5f6d8a4bf34a)
(use 'hg evolve' to update to its successor: e6048a693c0d)
$ hg glog
o 3:e6048a693c0d updated b
| () draft
| * 2:155349b645be added c
| | () draft
| @ 1:5f6d8a4bf34a added b
|/ () draft
o 0:9092f1db7931 added a
() draft
Test `hg evolve` evolve all the revisions specified by user:
$ hg evolve -r .::
update:[3] updated b
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
working directory is now at e6048a693c0d
move:[2] added c
atop:[3] updated b
working directory is now at e6048a693c0d