pick: remove transaction on the whole command (issue6037)
At its core, pick is a pretty straightforward and well-behaving command, it
uses functions already in core hg, it checks that wdir is clean and that
changeset to pick is not public, it checks if there happen to be merge
conflicts and can be --continue'd later, etc.
It is very similar to graft in core (it also uses mergemod.graft function), but
it obsoletes the original changeset. However, graft does not experience this
incorrect behavior from issue 6037.
What happens in the test case for this issue when we pick a revision that
touches both "a" and "b": mergemod.graft() takes the original changeset and
tries to apply it to the wdir, which results in "b" being marked as newly added
and ready to be committed, "a" updated with the new content and being marked as
modified, but "a" also has conflicts. Pick correctly notices this and saves its
state before asking for user intervention. So far so good. However, when the
command raises InterventionRequired to print a user-facing message and exit
while being wrapped in repo.transaction() context manager, the latter partially
undoes what mergemod.graft() did: it unmarks "b" as added. And when user
continues pick, "b" is therefore not tracked and is not included in the
resulting commit.
The transaction is not useful here, because it doesn't touch wdir (it's still
dirty), it doesn't remove pickstate (and other commands will refuse to work
until pick --abort or --continue), it just makes "b" untracked.
The solution is to use repo.transaction() only to wrap code that writes data to
hg store in the final stages of the command after all checks have passed and is
not expected to fail on trivial cases like merge conflicts. For example,
committing the picked changeset. But since pick uses repo.commit() for that,
and because that function already uses a transaction, wrapping it in another
transaction doesn't make sense.
$ . $TESTDIR/testlib/common.sh
setup
$ cat >> $HGRCPATH <<EOF
> [defaults]
> fold=-d "0 0"
> [extensions]
> evolve=
> [ui]
> logtemplate = '{rev} - {node|short} {desc|firstline} [{author}] ({phase}) {bookmarks}\n'
> EOF
$ hg init fold-tests
$ cd fold-tests/
$ hg debugbuilddag .+3:branchpoint+4*branchpoint+2
$ hg up 'desc("r7")'
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ hg bookmark bm1
$ hg log -G
o 10 - a8407f9a3dc1 r10 [debugbuilddag] (draft)
|
o 9 - 529dfc5bb875 r9 [debugbuilddag] (draft)
|
o 8 - abf57d94268b r8 [debugbuilddag] (draft)
|
| @ 7 - 4de32a90b66c r7 [debugbuilddag] (draft) bm1
| |
| o 6 - f69452c5b1af r6 [debugbuilddag] (draft)
| |
| o 5 - c8d03c1b5e94 r5 [debugbuilddag] (draft)
| |
| o 4 - bebd167eb94d r4 [debugbuilddag] (draft)
|/
o 3 - 2dc09a01254d r3 [debugbuilddag] (draft)
|
o 2 - 01241442b3c2 r2 [debugbuilddag] (draft)
|
o 1 - 66f7d451a68b r1 [debugbuilddag] (draft)
|
o 0 - 1ea73414a91b r0 [debugbuilddag] (draft)
Test various error case
$ hg fold --exact null::
abort: cannot fold the null revision
(no changeset checked out)
[255]
$ hg fold
abort: no revisions specified
[255]
$ hg fold --from
abort: no revisions specified
[255]
$ hg fold .
abort: must specify either --from or --exact
[255]
$ hg fold --from . --exact
abort: cannot use both --from and --exact
[255]
$ hg fold --from .
single revision specified, nothing to fold
[1]
$ hg fold '0::(7+10)' --exact
abort: cannot fold non-linear revisions (multiple heads given)
[255]
$ hg fold -r 4 -r 6 --exact
abort: cannot fold non-linear revisions (multiple roots given)
[255]
$ hg fold --from 10 1
abort: cannot fold non-linear revisions
(given revisions are unrelated to parent of working directory)
[255]
$ hg fold --exact -r "4 and not 4"
abort: specified revisions evaluate to an empty set
(use different revision arguments)
[255]
$ hg phase --public 0
$ hg fold --from -r 0
abort: cannot fold public changesets: 1ea73414a91b
(see 'hg help phases' for details)
[255]
Test actual folding
$ hg fold --from -r 'desc("r5")'
3 changesets folded
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
Checking whether the bookmarks are moved or not
$ hg log -G
@ 11 - 198b5c405d01 r5 [debugbuilddag] (draft) bm1
|
| o 10 - a8407f9a3dc1 r10 [debugbuilddag] (draft)
| |
| o 9 - 529dfc5bb875 r9 [debugbuilddag] (draft)
| |
| o 8 - abf57d94268b r8 [debugbuilddag] (draft)
| |
o | 4 - bebd167eb94d r4 [debugbuilddag] (draft)
|/
o 3 - 2dc09a01254d r3 [debugbuilddag] (draft)
|
o 2 - 01241442b3c2 r2 [debugbuilddag] (draft)
|
o 1 - 66f7d451a68b r1 [debugbuilddag] (draft)
|
o 0 - 1ea73414a91b r0 [debugbuilddag] (public)
(test inherited from test-evolve.t)
$ hg fold --from 6 # want to run hg fold 6
abort: hidden revision '6' was rewritten as: 198b5c405d01!
(use --hidden to access hidden revisions)
[255]
$ hg log -G
@ 11 - 198b5c405d01 r5 [debugbuilddag] (draft) bm1
|
| o 10 - a8407f9a3dc1 r10 [debugbuilddag] (draft)
| |
| o 9 - 529dfc5bb875 r9 [debugbuilddag] (draft)
| |
| o 8 - abf57d94268b r8 [debugbuilddag] (draft)
| |
o | 4 - bebd167eb94d r4 [debugbuilddag] (draft)
|/
o 3 - 2dc09a01254d r3 [debugbuilddag] (draft)
|
o 2 - 01241442b3c2 r2 [debugbuilddag] (draft)
|
o 1 - 66f7d451a68b r1 [debugbuilddag] (draft)
|
o 0 - 1ea73414a91b r0 [debugbuilddag] (public)
test fold --exact
$ hg fold --exact 'desc("r8") + desc("r10")'
abort: cannot fold non-linear revisions (multiple roots given)
[255]
$ hg fold --exact 'desc("r8")::desc("r10")'
3 changesets folded
$ hg log -G
o 12 - b568edbee6e0 r8 [debugbuilddag] (draft)
|
| @ 11 - 198b5c405d01 r5 [debugbuilddag] (draft) bm1
| |
| o 4 - bebd167eb94d r4 [debugbuilddag] (draft)
|/
o 3 - 2dc09a01254d r3 [debugbuilddag] (draft)
|
o 2 - 01241442b3c2 r2 [debugbuilddag] (draft)
|
o 1 - 66f7d451a68b r1 [debugbuilddag] (draft)
|
o 0 - 1ea73414a91b r0 [debugbuilddag] (public)
Test allow unstable
$ echo a > a
$ hg add a
$ hg commit '-m r11'
$ hg up '.^'
0 files updated, 0 files merged, 1 files removed, 0 files unresolved
(leaving bookmark bm1)
$ hg log -G
o 13 - 14d0e0da8e91 r11 [test] (draft) bm1
|
| o 12 - b568edbee6e0 r8 [debugbuilddag] (draft)
| |
@ | 11 - 198b5c405d01 r5 [debugbuilddag] (draft)
| |
o | 4 - bebd167eb94d r4 [debugbuilddag] (draft)
|/
o 3 - 2dc09a01254d r3 [debugbuilddag] (draft)
|
o 2 - 01241442b3c2 r2 [debugbuilddag] (draft)
|
o 1 - 66f7d451a68b r1 [debugbuilddag] (draft)
|
o 0 - 1ea73414a91b r0 [debugbuilddag] (public)
$ cat << EOF >> .hg/hgrc
> [experimental]
> evolution = createmarkers, allnewcommands
> EOF
$ hg fold --from 'desc("r4")'
abort: fold will orphan 1 descendants
(see 'hg help evolution.instability')
[255]
$ hg fold --from 'desc("r3")::desc("r11")'
abort: fold will orphan 1 descendants
(see 'hg help evolution.instability')
[255]
test --user variant
$ cat << EOF >> .hg/hgrc
> [experimental]
> evolution = createmarkers, allnewcommands
> EOF
$ cat << EOF >> .hg/hgrc
> [experimental]
> evolution = all
> EOF
$ hg fold --exact 'desc("r5") + desc("r11")' --user 'Victor Rataxes <victor@rhino.savannah>'
2 changesets folded
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ hg log -G
@ 14 - 29b470a33594 r5 [Victor Rataxes <victor@rhino.savannah>] (draft) bm1
|
| o 12 - b568edbee6e0 r8 [debugbuilddag] (draft)
| |
o | 4 - bebd167eb94d r4 [debugbuilddag] (draft)
|/
o 3 - 2dc09a01254d r3 [debugbuilddag] (draft)
|
o 2 - 01241442b3c2 r2 [debugbuilddag] (draft)
|
o 1 - 66f7d451a68b r1 [debugbuilddag] (draft)
|
o 0 - 1ea73414a91b r0 [debugbuilddag] (public)
$ hg fold --from 'desc("r4")' -U
2 changesets folded
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ hg log -G
@ 15 - 91880abed0f2 r4 [test] (draft) bm1
|
| o 12 - b568edbee6e0 r8 [debugbuilddag] (draft)
|/
o 3 - 2dc09a01254d r3 [debugbuilddag] (draft)
|
o 2 - 01241442b3c2 r2 [debugbuilddag] (draft)
|
o 1 - 66f7d451a68b r1 [debugbuilddag] (draft)
|
o 0 - 1ea73414a91b r0 [debugbuilddag] (public)
Test order of proposed commit message
$ hg fold --exact --hidden -r 4 -r 5 -r 6
2 new content-divergent changesets
3 changesets folded
$ hg log -r tip -T '{desc}'
r4
r5
r6 (no-eol)
$ hg fold --exact --hidden -r 6 -r 4 -r 5
3 changesets folded
$ hg log -r tip -T '{desc}'
r4
r5
r6 (no-eol)
$ cd ..