stack: fix phasecache._phasesets check logic When _phasesets is not None, it's a list, and it contains set()s of revisions in a specific phase, starting from public, draft, secret and so on. But since repos are supposed to have the majority of revisions in public phase, the first element of this list is not a (potentially huge) set, but None. Previously this code tried to check if there's any element that is None, and was always finding None at index 0, so the short path was executed every time and the rest of the function was never used.

     1

import hghave

     2

     3

@hghave.check("docgraph-ext", "Extension to generate graph from repository")

     4

def docgraph():

     5

    try:

     6

        import hgext.docgraph

     7

        hgext.docgraph.cmdtable # trigger import

     8

    except ImportError:

     9

        try:

    10

            import hgext3rd.docgraph

    11

            hgext3rd.docgraph.cmdtable # trigger import

    12

        except ImportError:

    13

            return False

    14

    return True