evolve: create a new commit instead of amending one of the divergents This patch changes the behavior of evolve command while resolving content-divergence to create a new commit instead of amending one of the divergent ones. In past, I have made this change, backed out this change and now today again I am doing this change, so let's dive in some history. Using cmdrewrite.amend() was never a good option as that requires hack to delete the evolvestate and also gives us less control over things. We can't make the commit on top of different parents as that of content-divergent ones. Due to all these, I first made this change to create a new commit instead of amending one. But, after few days, there was flakiness observed in the tests and turned out that we need to do some dirstate dance as repo.dirstate.setparents() does not always fix the dirstate. That flakiness was a blocker for progress at that time and we decided to switch to amend back so that we can have things working with some hacks and we can later fix the implementation part. Now, yesterday while tackling resolving content-divergence of a stack which is as follows: C1 C2 | | B1 B2 | | A1 A2 \/ base where, A1-A2, B1-B2, C1-C2 are content-divergent with each other. Now we can resolve A1-A2 very well because they have the same parent and let's say that resolution leads to A3. Now, we want to resolve B1-B2 and make the new resolution commit on top of A3 so that we can end up something like: C3 | B3 | A3 | base however, amending one of the divergent changesets, it's not possible to create a commit on a different parent like A3 here without some relocation. We should prevent relocation as that may leads to some conflicts and should change the parent before committing. So, looking ahead, we can't move with using amend as still using that we will need some relocation hacks making code ugly and prone to bad behaviors, bugs. Let's change back to creating a new commit so that we can move forward in a good way. About repo.dirstate.setparents() not setting the dirstate, I have researched yesterday night about how we can do that and found out that we can use cmdrewrite._uncommitdirstate() here. Expect upcoming patches to improve the documentation of that function. There are lot of test changes because of change in hash but there is no behavior change. The only behavior change is in test-evolve-abort-contentdiv.t which is nice because creating a new commit helps us in stripping that while aborting. We have a lot of testing of content-divergence and no behavior change gives enough confidence for making this change. I reviewed the patch carefully to make sure there is no behavior change and I suggest reviewer to do the same.

     1

====================================

     2

Testing head checking code: Case D-6

     3

====================================

     4

     5

Mercurial checks for the introduction of new heads on push. Evolution comes

     6

into play to detect if existing branches on the server are being replaced by

     7

some of the new one we push.

     8

     9

This case is part of a series of tests checking this behavior.

    10

    11

Category D: remote head is "obs-affected" locally, but result is not part of the push

    12

TestCase 6: single changeset, superseeded then pruned (on a new changeset unpushed) changeset

    13

    14

This is a partial push variation of case B-6

    15

    16

.. old-state:

    17

..

    18

.. * 1 changeset branch

    19

..

    20

.. new-state:

    21

..

    22

.. * old branch is rewritten onto another one,

    23

.. * the new version is then pruned.

    24

..

    25

.. expected-result:

    26

..

    27

.. * push denied

    28

..

    29

.. graph-summary:

    30

..

    31

..   A ø⇠⊗ A'

    32

..     | |

    33

.. C ◔ | ○ B

    34

..    \|/

    35

..     ●

    36

    37

  $ . $TESTDIR/testlib/push-checkheads-util.sh

    38

    39

Test setup

    40

----------

    41

    42

  $ mkdir D6

    43

  $ cd D6

    44

  $ setuprepos

    45

  creating basic server and client repo

    46

  updating to branch default

    47

  2 files updated, 0 files merged, 0 files removed, 0 files unresolved

    48

  $ cd client

    49

  $ hg up 0

    50

  0 files updated, 0 files merged, 1 files removed, 0 files unresolved

    51

  $ mkcommit B0

    52

  created new head

    53

  $ mkcommit A1

    54

  $ hg up '0'

    55

  0 files updated, 0 files merged, 2 files removed, 0 files unresolved

    56

  $ mkcommit C0

    57

  created new head

    58

  $ hg debugobsolete `getid "desc(A0)"` `getid "desc(A1)"`

    59

  obsoleted 1 changesets

    60

  $ hg debugobsolete --record-parents `getid "desc(A1)"`

    61

  obsoleted 1 changesets

    62

  $ hg log -G --hidden

    63

  @  0f88766e02d6 (draft): C0

    64

  |

    65

  | x  ba93660aff8d (draft): A1

    66

  | |

    67

  | o  74ff5441d343 (draft): B0

    68

  |/

    69

  | x  8aaa48160adc (draft): A0

    70

  |/

    71

  o  1e4be0697311 (public): root

    72

    73

    74

Actual testing

    75

--------------

    76

    77

  $ hg push --rev 'desc(C0)'

    78

  pushing to $TESTTMP/D6/server (glob)

    79

  searching for changes

    80

  abort: push creates new remote head 0f88766e02d6!

    81

  (merge or see 'hg help push' for details about pushing new heads)

    82

  [255]

    83

    84

  $ cd ../..