evolve: create a new commit instead of amending one of the divergents This patch changes the behavior of evolve command while resolving content-divergence to create a new commit instead of amending one of the divergent ones. In past, I have made this change, backed out this change and now today again I am doing this change, so let's dive in some history. Using cmdrewrite.amend() was never a good option as that requires hack to delete the evolvestate and also gives us less control over things. We can't make the commit on top of different parents as that of content-divergent ones. Due to all these, I first made this change to create a new commit instead of amending one. But, after few days, there was flakiness observed in the tests and turned out that we need to do some dirstate dance as repo.dirstate.setparents() does not always fix the dirstate. That flakiness was a blocker for progress at that time and we decided to switch to amend back so that we can have things working with some hacks and we can later fix the implementation part. Now, yesterday while tackling resolving content-divergence of a stack which is as follows: C1 C2 | | B1 B2 | | A1 A2 \/ base where, A1-A2, B1-B2, C1-C2 are content-divergent with each other. Now we can resolve A1-A2 very well because they have the same parent and let's say that resolution leads to A3. Now, we want to resolve B1-B2 and make the new resolution commit on top of A3 so that we can end up something like: C3 | B3 | A3 | base however, amending one of the divergent changesets, it's not possible to create a commit on a different parent like A3 here without some relocation. We should prevent relocation as that may leads to some conflicts and should change the parent before committing. So, looking ahead, we can't move with using amend as still using that we will need some relocation hacks making code ugly and prone to bad behaviors, bugs. Let's change back to creating a new commit so that we can move forward in a good way. About repo.dirstate.setparents() not setting the dirstate, I have researched yesterday night about how we can do that and found out that we can use cmdrewrite._uncommitdirstate() here. Expect upcoming patches to improve the documentation of that function. There are lot of test changes because of change in hash but there is no behavior change. The only behavior change is in test-evolve-abort-contentdiv.t which is nice because creating a new commit helps us in stripping that while aborting. We have a lot of testing of content-divergence and no behavior change gives enough confidence for making this change. I reviewed the patch carefully to make sure there is no behavior change and I suggest reviewer to do the same.

     1

     2

  $ . ${TESTDIR}/testlib/pythonpath.sh

     3

     4

  $ cat >> $HGRCPATH <<EOF

     5

  > [defaults]

     6

  > amend=-d "0 0"

     7

  > [web]

     8

  > push_ssl = false

     9

  > allow_push = *

    10

  > [phases]

    11

  > publish = False

    12

  > [experimental]

    13

  > bundle2-exp=False # < Mercurial-4.0

    14

  > [devel]

    15

  > legacy.exchange=bundle1

    16

  > [extensions]

    17

  > EOF

    18

    19

  $ mkcommit() {

    20

  >    echo "$1" > "$1"

    21

  >    hg add "$1"

    22

  >    hg ci -m "add $1"

    23

  > }

    24

    25

    26

  $ hg init server

    27

    28

Try the multiple ways to setup the extension

    29

    30

  $ hg -R server log --config 'extensions.evolve.serveronly='

    31

  $ hg -R server log --config "extensions.evolve.serveronly=${SRCDIR}/hgext3rd/evolve/serveronly.py"

    32

  $ PYTHONPATH=$HGTEST_ORIG_PYTHONPATH hg -R server log --config "extensions.evolve.serveronly=${SRCDIR}/hgext3rd/evolve/serveronly.py"

    33

    34

setup repo

    35

    36

  $ echo "[extensions]" >> ./server/.hg/hgrc

    37

  $ echo "evolve.serveronly=" >> ./server/.hg/hgrc

    38

  $ hg serve -R server -n test -p $HGPORT -d --pid-file=hg.pid -A access.log -E errors.log --traceback

    39

  $ cat hg.pid >> $DAEMON_PIDS

    40

    41

  $ hg clone http://localhost:$HGPORT/ client

    42

  no changes found

    43

  updating to branch default

    44

  0 files updated, 0 files merged, 0 files removed, 0 files unresolved

    45

  $ cat ./errors.log

    46

  $ echo "[extensions]" >> ./client/.hg/hgrc

    47

  $ echo "evolve=" >> ./client/.hg/hgrc

    48

  $ cp -r client other

    49

    50

Smoke testing

    51

===============

    52

    53

  $ cd client

    54

  $ mkcommit 0

    55

  $ mkcommit a

    56

  $ hg push

    57

  pushing to http://localhost:$HGPORT/

    58

  searching for changes

    59

  abort: remote error:

    60

  incompatible Mercurial client; bundle2 required

    61

  (see https://www.mercurial-scm.org/wiki/IncompatibleClient)

    62

  [255]

    63

  $ cat ../errors.log