evolve: create a new commit instead of amending one of the divergents This patch changes the behavior of evolve command while resolving content-divergence to create a new commit instead of amending one of the divergent ones. In past, I have made this change, backed out this change and now today again I am doing this change, so let's dive in some history. Using cmdrewrite.amend() was never a good option as that requires hack to delete the evolvestate and also gives us less control over things. We can't make the commit on top of different parents as that of content-divergent ones. Due to all these, I first made this change to create a new commit instead of amending one. But, after few days, there was flakiness observed in the tests and turned out that we need to do some dirstate dance as repo.dirstate.setparents() does not always fix the dirstate. That flakiness was a blocker for progress at that time and we decided to switch to amend back so that we can have things working with some hacks and we can later fix the implementation part. Now, yesterday while tackling resolving content-divergence of a stack which is as follows: C1 C2 | | B1 B2 | | A1 A2 \/ base where, A1-A2, B1-B2, C1-C2 are content-divergent with each other. Now we can resolve A1-A2 very well because they have the same parent and let's say that resolution leads to A3. Now, we want to resolve B1-B2 and make the new resolution commit on top of A3 so that we can end up something like: C3 | B3 | A3 | base however, amending one of the divergent changesets, it's not possible to create a commit on a different parent like A3 here without some relocation. We should prevent relocation as that may leads to some conflicts and should change the parent before committing. So, looking ahead, we can't move with using amend as still using that we will need some relocation hacks making code ugly and prone to bad behaviors, bugs. Let's change back to creating a new commit so that we can move forward in a good way. About repo.dirstate.setparents() not setting the dirstate, I have researched yesterday night about how we can do that and found out that we can use cmdrewrite._uncommitdirstate() here. Expect upcoming patches to improve the documentation of that function. There are lot of test changes because of change in hash but there is no behavior change. The only behavior change is in test-evolve-abort-contentdiv.t which is nice because creating a new commit helps us in stripping that while aborting. We have a lot of testing of content-divergence and no behavior change gives enough confidence for making this change. I reviewed the patch carefully to make sure there is no behavior change and I suggest reviewer to do the same.

     1

# Extension which prevent changeset to be turn public by push operation

     2

#

     3

# Copyright 2011 Logilab SA        <contact@logilab.fr>

     4

#

     5

# This software may be used and distributed according to the terms of the

     6

# GNU General Public License version 2 or any later version.

     7

     8

     9

from mercurial import extensions, util

    10

from mercurial import discovery

    11

    12

def checkpublish(orig, repo, remote, outgoing, *args):

    13

    14

    # is remote publishing?

    15

    publish = True

    16

    if 'phases' in remote.listkeys('namespaces'):

    17

        remotephases = remote.listkeys('phases')

    18

        publish = remotephases.get('publishing', False)

    19

    20

    npublish = 0

    21

    if publish:

    22

        for rev in outgoing.missing:

    23

            if repo[rev].phase():

    24

                npublish += 1

    25

    if npublish:

    26

        repo.ui.warn("Push would publish %s changesets" % npublish)

    27

    28

    ret = orig(repo, remote, outgoing, *args)

    29

    if npublish:

    30

        raise util.Abort("Publishing push forbidden",

    31

                         hint="Use `hg phase -p <rev>` to manually publish them")

    32

    33

    return ret

    34

    35

def uisetup(ui):

    36

    extensions.wrapfunction(discovery, 'checkheads', checkpublish)