touch: fix the inconsistent behavior of divergence catching logic (issue6107) When touching a node, the way we check if it can lead to divergence is we look at the successors sets of the rev being touched. And if there is successor revs exists (excluding the case when that successor set is (A,) for rev A) that means there will be divergence and we warn the user. This works fine but there is still a case (which is not covered by looking at successor sets) which can lead to divergence. That case is: when there is already a revision exists which is divergent to the revision being touched. And performing the touch would revive that "dead" divergence. (Dead because one of the revision is obsolete which is the one we are touching) And to see if there is any rev which is divergent to a particular rev we already have a function which we can use here i.e. `evolvecmd.divergentsets(repo, ctx_being_touched)` Changes in test file demonstrate the fixed behaviour.

     1

[flake8]

     2

ignore =

     3

         #closing bracket does not match indentation of opening bracket's line

     4

         E123,

     5

         # closing bracket does not match visual indentation

     6

         E124,

     7

         # visually indented line with same indent as next logical line

     8

         E129,

     9

         # at least two spaces before inline comment

    10

         E261,

    11

         # too many leading '#' for block comment

    12

         E266,

    13

         # expected 2 blank lines, found 0

    14

         E302,

    15

         # expected 2 blank lines after end of function or class

    16

         E305,

    17

         # module level import not at top of file

    18

         E402,

    19

         # line too long (82 > 79 characters)

    20

         E501,

    21

         # do not assign a lambda expression, use a def

    22

         E731,

    23

         # class names should use CapWords convention

    24

         N801,

    25

         # line break occurred before a binary operator

    26

         W503

    27

builtins=xrange, execfile

    28