amend: query the wdir parent after taking lock (issue5266) If we query wdir parent without taking a lock, that can lead to bugs because the wdir parent can change is another process has changed the wdir parent. One such example of this was issue 5266. When a user is running amend and that amend is waiting for commit message, the user runs another amend which waits for lock. The second amend is waiting for lock, but has already read the description from the parent of working directory to use. Once the first amend completes the wdir parent changes but we still have the description from an old wdir parent. This patch fixes the bug by querying the description after taking lock. Attempts were made to add test for this but the results were unstable because they depend on time in which lock is released.

     1

import hghave

     2

     3

@hghave.check("docgraph-ext", "Extension to generate graph from repository")

     4

def docgraph():

     5

    try:

     6

        import hgext.docgraph

     7

        hgext.docgraph.cmdtable # trigger import

     8

    except ImportError:

     9

        try:

    10

            import hgext3rd.docgraph

    11

            hgext3rd.docgraph.cmdtable # trigger import

    12

        except ImportError:

    13

            return False

    14

    return True