next: cleanup logic around return by returning early In the cmdnext function, there are some conditionals which returns early and some which sets a result value to be returned later. Let's return from all the conditionals early. There are if, elif and else involved, so it's sure we will end up in one of the conditional, each conditional will return, so it's guranteed that we are returning the correct value and returning everytime.

     1

# utility to setup pythonpath to point into the tested repository

     2

     3

export SRCDIR=`dirname $TESTDIR`

     4

if [ -n "$PYTHONPATH" ]; then

     5

    export HGTEST_ORIG_PYTHONPATH=$PYTHONPATH

     6

    export PYTHONPATH=$SRCDIR:$PYTHONPATH

     7

else

     8

    export PYTHONPATH=$SRCDIR

     9

fi