directaccess: use cached filteredrevs Before this patch we were calling directly repoview.computehidden(repo) to compute the revisions visible with direct access, without going through the caching mechanism for the filtered revisions. There was two issues with that: (1) Performance: We were not leverating the cached values of the 'visible' revs (2) Stability: If there were to be a cache inconsistency with the computation of 'visible' we would crash in the branchmap consistency check partial.validfor. Consider the scenario of rebase with bookmarks: - when we delete a bookmark on an obsolete changeset (like what rebase does when moving the bookmark after rebasing the changesets) - then this changes the value returned by repoview.computehidden(repo) as bookmarks are used as dynamic blockers in repoview.computehidden(repo) - as of now, we don't invalidate the cache in the case of bookmark change - if we have a cached value from before the bookmark change, repoview.filterrevs(repo, 'visible') considers the cached value correct and returns something different than repoview.computehidden(repo) - in turn, if we use repoview.computehidden(repo) in directaccess, the subset relationship is broken and the cache consistency assertion (parial.validfor) fails if branchmap.updatecache is called in this time window This patch leverages the caching infrastructure in place to speed up the computation of the filteredrevs for visible-directaccess-nowarn and visible-directaccess-warn. Incidentally it prevents the bug discussed in (2) from crashing when running a rebase with a bookmark. Note that there still needs to be a fix in core for the case discussed in (2). The test for this side of the fix (not core's fix for (2) is very hard to implement without introducing a lot of dependencies and does not belong here. It is much easier to have the test of the fix for the scenario (2) in core along with the fix.

     1

PYTHON=python

     2

HG=`which hg`

     3

VERSION=$(shell python setup.py --version)

     4

     5

     6

help:

     7

	@echo 'Commonly used make targets:'

     8

	@echo '  tests              - run all tests in the automatic test suite'

     9

	@echo '  all-version-tests - run all tests against many hg versions'

    10

	@echo '  tests-%s           - run all tests in the specified hg version'

    11

    12

all: help

    13

    14

tests:

    15

	cd tests && $(PYTHON) run-tests.py --with-hg=$(HG) $(TESTFLAGS)

    16

    17

test-%:

    18

	cd tests && $(PYTHON) run-tests.py --with-hg=$(HG) $(TESTFLAGS) $@

    19

    20

tests-%:

    21

	@echo "Path to crew repo is $(CREW) - set this with CREW= if needed."

    22

	hg -R $(CREW) checkout $$(echo $@ | sed s/tests-//) && \

    23

	(cd $(CREW) ; $(MAKE) clean ) && \

    24

	cd tests && $(PYTHON) $(CREW)/tests/run-tests.py $(TESTFLAGS)

    25

    26

all-version-tests: tests-1.3.1 tests-1.4.3 tests-1.5.4 \

    27

                   tests-1.6.4 tests-1.7.5 tests-1.8 tests-tip

    28

    29

deb-prepare:

    30

	python setup.py sdist --dist-dir ..

    31

	mv -f ../hg-evolve-$(VERSION).tar.gz ../mercurial-evolve_$(VERSION).orig.tar.gz

    32

	tar xf ../mercurial-evolve_$(VERSION).orig.tar.gz

    33

	rm -rf ../mercurial-evolve_$(VERSION).orig

    34

	mv hg-evolve-$(VERSION) ../mercurial-evolve_$(VERSION).orig

    35

	cp -r debian/ ../mercurial-evolve_$(VERSION).orig/

    36

	@cd ../mercurial-evolve_$(VERSION).orig && echo 'debian build directory ready at' `pwd`

    37

    38

.PHONY: tests all-version-tests