cleanup
authorSylvain Thénault <sylvain.thenault@logilab.fr>
Wed, 27 Jan 2010 10:00:35 +0100
changeset 4395 e50b71c0dd87
parent 4394 b98fbca17e9e
child 4396 98e98a5aa399
cleanup
mixins.py
web/formfields.py
--- a/mixins.py	Wed Jan 27 10:00:19 2010 +0100
+++ b/mixins.py	Wed Jan 27 10:00:35 2010 +0100
@@ -50,7 +50,7 @@
                            entities=entities)
         if entities:
             return [e for e in res if e.e_schema == self.e_schema]
-        return res.filtered_rset(lambda x: x.e_schema == self.e_schema, self.cw_col)
+        return res.filtered_rset(lambda x: x.e_schema is self.e_schema, self.cw_col)
 
     def iterchildren(self, _done=None):
         if _done is None:
--- a/web/formfields.py	Wed Jan 27 10:00:19 2010 +0100
+++ b/web/formfields.py	Wed Jan 27 10:00:35 2010 +0100
@@ -336,7 +336,7 @@
                 return True
             except UnmodifiedField:
                 return False
-            if form.edited_entity.has_eid() and previous_value == new_value:
+            if previous_value == new_value:
                 return False # not modified
             return True
         return False
@@ -751,6 +751,7 @@
 
 
 class RelationField(Field):
+    """the relation field to edit non final relations of an entity"""
 
     @staticmethod
     def fromcardinality(card, **kwargs):