[cleanup] some notes stable
authorSylvain Thénault <sylvain.thenault@logilab.fr>
Tue, 30 Mar 2010 13:31:21 +0200
branchstable
changeset 5080 cfc7c2b24f9e
parent 5079 e646047f80cb
child 5081 2ea98b8512dd
[cleanup] some notes
cwvreg.py
web/views/sessions.py
--- a/cwvreg.py	Tue Mar 30 13:29:55 2010 +0200
+++ b/cwvreg.py	Tue Mar 30 13:31:21 2010 +0200
@@ -262,6 +262,7 @@
         self.schema = None
         self.initialized = False
         self.reset()
+        # XXX give force_reload (or refactor [re]loading...)
         if self.config.mode != 'test':
             # don't clear rtags during test, this may cause breakage with
             # manually imported appobject modules
--- a/web/views/sessions.py	Tue Mar 30 13:29:55 2010 +0200
+++ b/web/views/sessions.py	Tue Mar 30 13:31:21 2010 +0200
@@ -22,6 +22,8 @@
         #assert isinstance(self.authmanager, RepositoryAuthenticationManager)
         self._sessions = {}
 
+    # dump_data / restore_data to avoid loosing open sessions on registry
+    # reloading
     def dump_data(self):
         return self._sessions
     def restore_data(self, data):
@@ -38,9 +40,9 @@
         if self.has_expired(session):
             self.close_session(session)
             raise InvalidSession()
-        # give an opportunity to auth manager to hijack the session
-        # (necessary with the RepositoryAuthenticationManager in case
-        #  the connection to the repository has expired)
+        # give an opportunity to auth manager to hijack the session (necessary
+        # with the RepositoryAuthenticationManager in case the connection to the
+        # repository has expired)
         try:
             session = self.authmanager.validate_session(req, session)
             # necessary in case session has been hijacked