cleanups stable
authorSylvain Thénault <sylvain.thenault@logilab.fr>
Mon, 31 Jan 2011 17:31:09 +0100
branchstable
changeset 6926 2cda8f1b4fae
parent 6925 352db17719d2
child 6927 340aba0c8c9e
cleanups
view.py
web/views/basecontrollers.py
web/views/idownloadable.py
web/views/primary.py
--- a/view.py	Mon Jan 31 17:30:48 2011 +0100
+++ b/view.py	Mon Jan 31 17:31:09 2011 +0100
@@ -385,6 +385,7 @@
     def entity_call(self, entity, **kwargs):
         raise NotImplementedError()
 
+
 class StartupView(View):
     """base class for views which doesn't need a particular result set to be
     displayed (so they can always be displayed !)
--- a/web/views/basecontrollers.py	Mon Jan 31 17:30:48 2011 +0100
+++ b/web/views/basecontrollers.py	Mon Jan 31 17:31:09 2011 +0100
@@ -426,6 +426,7 @@
                   selectargs=None, renderargs=None):
         if eid is not None:
             rset = self._cw.eid_rset(eid)
+            # XXX set row=0
         elif self._cw.form.get('rql'):
             rset = self._cw.execute(self._cw.form['rql'])
         else:
--- a/web/views/idownloadable.py	Mon Jan 31 17:30:48 2011 +0100
+++ b/web/views/idownloadable.py	Mon Jan 31 17:31:09 2011 +0100
@@ -50,8 +50,7 @@
 
 
 class DownloadBox(component.EntityCtxComponent):
-    __regid__ = 'download_box'
-    # no download box for images
+    __regid__ = 'download_box'    # no download box for images
     __select__ = (component.EntityCtxComponent.__select__ &
                   adaptable('IDownloadable') & ~has_mimetype('image/'))
 
--- a/web/views/primary.py	Mon Jan 31 17:30:48 2011 +0100
+++ b/web/views/primary.py	Mon Jan 31 17:31:09 2011 +0100
@@ -100,6 +100,7 @@
         self.w(u'<div class="%s">' % context)
         for comp in self._cw.vreg['ctxcomponents'].poss_visible_objects(
             self._cw, rset=self.cw_rset, view=self, context=context):
+            # XXX bw compat code
             try:
                 comp.render(w=self.w, row=self.cw_row, view=self)
             except TypeError: