merge 3.5/stable heads stable
authorAurelien Campeas <aurelien.campeas@logilab.fr>
Fri, 12 Feb 2010 13:33:54 +0100
branchstable
changeset 4559 242e76469664
parent 4558 259e7ef7c373 (current diff)
parent 4555 8968c50818db (diff)
child 4561 029e08b1723f
child 4562 7e781ff78726
child 4636 edafa2343dd7
merge 3.5/stable heads
--- a/server/sources/ldapuser.py	Fri Feb 12 13:32:14 2010 +0100
+++ b/server/sources/ldapuser.py	Fri Feb 12 13:33:54 2010 +0100
@@ -78,7 +78,7 @@
         ('auth-realm',
          {'type' : 'string',
           'default': None,
-          'help': 'realm to use when using gssapp/kerberos authentication.',
+          'help': 'realm to use when using gssapi/kerberos authentication.',
           'group': 'ldap-source', 'inputlevel': 1,
           }),
 
--- a/toolsutils.py	Fri Feb 12 13:32:14 2010 +0100
+++ b/toolsutils.py	Fri Feb 12 13:33:54 2010 +0100
@@ -10,6 +10,7 @@
 # XXX move most of this in logilab.common (shellutils ?)
 
 import os, sys
+import subprocess
 from os import listdir, makedirs, environ, chmod, walk, remove
 from os.path import exists, join, abspath, normpath
 
@@ -72,8 +73,8 @@
     user decision
     """
     import shutil
-    p_output = os.popen('diff -u %s %s' % (appl_file, ref_file), 'r')
-    diffs = p_output.read()
+    pipe = subprocess.Popen(['diff', '-u', appl_file, ref_file], stdout=subprocess.PIPE)
+    diffs = pipe.stdout.read()
     if diffs:
         if askconfirm:
             print