merge stable
authorAlexandre Fayolle <alexandre.fayolle@logilab.fr>
Mon, 08 Feb 2010 15:28:18 +0100
branchstable
changeset 4504 f1d505f979b3
parent 4500 81021d62138f (diff)
parent 4502 1422589c35a0 (current diff)
child 4505 a82af6b000f2
merge
--- a/server/hooks.py	Mon Feb 08 10:07:52 2010 +0100
+++ b/server/hooks.py	Mon Feb 08 15:28:18 2010 +0100
@@ -58,8 +58,6 @@
     if _UNIQUE_CONSTRAINTS_HOLDER is session:
         _UNIQUE_CONSTRAINTS_HOLDER = None
         _UNIQUE_CONSTRAINTS_LOCK.release()
-    else:
-        assert _UNIQUE_CONSTRAINTS_HOLDER is None
 
 
 def relation_deleted(session, eidfrom, rtype, eidto):
--- a/server/session.py	Mon Feb 08 10:07:52 2010 +0100
+++ b/server/session.py	Mon Feb 08 15:28:18 2010 +0100
@@ -461,9 +461,21 @@
                     self.debug('%s session %s done', trstate, self.id)
                 except:
                     self.exception('error while %sing', trstate)
+                    # if error on [pre]commit:
+                    #
+                    # * set .failed = True on the operation causing the failure
+                    # * call revert<event>_event on processed operations
+                    # * call rollback_event on *all* operations
+                    #
+                    # that seems more natural than not calling rollback_event
+                    # for processed operations, and allow generic rollback
+                    # instead of having to implements rollback, revertprecommit
+                    # and revertcommit, that will be enough in mont case.
                     operation.failed = True
                     for operation in processed:
                         operation.handle_event('revert%s_event' % trstate)
+                    # res
+                    self.pending_operations[:] = processed + self.pending_operations
                     self.rollback(reset_pool)
                     raise
             self.pool.commit()