# HG changeset patch
# User Laura Médioni <laura.medioni@logilab.fr>
# Date 1453216276 -3600
# Node ID ffef75b7a26ea8982635b621d612b640c614daf5
# Parent  0796b6191cea937d3a70f7ff81b7463d9dc2b17c
[pylint] Avoid invalid-name on schema relation class names

diff -r 0796b6191cea -r ffef75b7a26e cubicweb/pylintext.py
--- a/cubicweb/pylintext.py	Wed Jan 20 08:26:30 2016 +0100
+++ b/cubicweb/pylintext.py	Tue Jan 19 16:11:16 2016 +0100
@@ -5,6 +5,7 @@
 * add yams base types to yams.buildobjs module
 * add data() function to uiprops module's namespace
 * avoid 'abstract method not implemented' for `cell_call`, `entity_call`, `render_body`
+* avoid invalid-name on schema relation class names
 
 TODO:
 * avoid invalid class name for predicates and predicates
@@ -63,6 +64,22 @@
   return u''
 ''')
         module.locals['data'] = fake.locals['data']
+    # handle lower case with underscores for relation names in schema.py
+    if not module.qname().endswith('.schema'):
+        return
+    schema_locals = module.locals
+    for assnodes in schema_locals.values():
+        for node in assnodes:
+            if not isinstance(node, ClassDef):
+                continue
+            # XXX can we infer ancestor classes? it would be better to know for sure that
+            # one of the mother classes is yams.buildobjs.RelationDefinition for instance
+            for base in node.basenames:
+                if base in ('RelationDefinition', 'ComputedRelation', 'RelationType'):
+                    new_name = node.name.replace('_', '').capitalize()
+                    schema_locals[new_name] = schema_locals[node.name]
+                    del schema_locals[node.name]
+                    node.name = new_name
 
 
 def cubicweb_abstractmethods_transform(classdef):