# HG changeset patch
# User Nicolas Chauvat <nicolas.chauvat@logilab.fr>
# Date 1552470005 -3600
# Node ID fa565be41647e50d96af4b07de3dd18706384a5c
# Parent  194e9ae964ede16442832c7521a2af799ddbef7e
[server.querier] remove useless indirections ExecutionPlan.{syssource,rqlhelper,schema}

Simpler is better.

diff -r 194e9ae964ed -r fa565be41647 cubicweb/server/querier.py
--- a/cubicweb/server/querier.py	Wed Mar 13 10:26:15 2019 +0100
+++ b/cubicweb/server/querier.py	Wed Mar 13 10:40:05 2019 +0100
@@ -160,14 +160,9 @@
         self.args = args or {}
         # cnx executing the query
         self.cnx = cnx
-        # quick reference to the system source
-        self.syssource = cnx.repo.system_source
         # execution steps
         self.steps = []
-        # various resource accesors
         self.querier = querier
-        self.schema = querier.schema
-        self.rqlhelper = cnx.vreg.rqlhelper
         # tracing token for debugging
         self.rql_query_tracing_token = None
 
@@ -176,7 +171,7 @@
         self.steps.append(step)
 
     def sqlexec(self, sql, args=None):
-        return self.syssource.sqlexec(self.cnx, sql, args)
+        return self.cnx.repo.system_source.sqlexec(self.cnx, sql, args)
 
     def execute(self):
         """execute a plan and return resulting rows"""
@@ -215,9 +210,9 @@
         else:
             noinvariant = ()
         if cached is None:
-            self.rqlhelper.simplify(union)
+            self.cnx.vreg.rqlhelper.simplify(union)
             self.querier.rqlannotator.annotate(union)
-            set_qdata(self.schema.rschema, union, noinvariant)
+            set_qdata(self.querier.schema.rschema, union, noinvariant)
         if union.has_text_query:
             self.cache_key = None
 
@@ -313,8 +308,8 @@
             for sol in solutions:
                 sol[newvarname] = nvartype
         select.clean_solutions(solutions)
-        add_types_restriction(self.schema, select)
-        self.rqlhelper.annotate(rqlst)
+        add_types_restriction(self.querier.schema, select)
+        self.cnx.vreg.rqlhelper.annotate(rqlst)
         self.preprocess(rqlst, security=False)
         return rqlst
 
@@ -344,7 +339,7 @@
     def add_relation_def(self, rdef):
         """add an relation definition to build"""
         edef, rtype, value = rdef
-        if self.schema[rtype].rule:
+        if self.querier.schema[rtype].rule:
             raise QueryError("'%s' is a computed relation" % rtype)
         self.r_defs.add(rdef)
         if not isinstance(edef, int):