# HG changeset patch # User Pierre-Yves David # Date 1364911372 -7200 # Node ID f31e2d6f1b53ad008f8c6fadff9e689bfaad7d1f # Parent 667cc27e9d12d3c00da5e14afa0a2fe93f8229a6 [test] use the right order in some assertEqual The unittest2 function use ``(expected, got)`` order. diff -r 667cc27e9d12 -r f31e2d6f1b53 server/test/unittest_session.py --- a/server/test/unittest_session.py Fri Mar 29 18:00:37 2013 +0100 +++ b/server/test/unittest_session.py Tue Apr 02 16:02:52 2013 +0200 @@ -17,6 +17,7 @@ # with CubicWeb. If not, see . from cubicweb.devtools.testlib import CubicWebTC +from cubicweb.server.session import HOOKS_ALLOW_ALL, HOOKS_DENY_ALL class InternalSessionTC(CubicWebTC): def test_dbapi_query(self): @@ -29,36 +30,36 @@ def test_hooks_control(self): session = self.session - self.assertEqual(session.hooks_mode, session.HOOKS_ALLOW_ALL) - self.assertEqual(session.disabled_hook_categories, set()) - self.assertEqual(session.enabled_hook_categories, set()) - self.assertEqual(len(session._txs), 1) + self.assertEqual(HOOKS_ALLOW_ALL, session.hooks_mode) + self.assertEqual(set(), session.disabled_hook_categories) + self.assertEqual(set(), session.enabled_hook_categories) + self.assertEqual(1, len(session._txs)) with session.deny_all_hooks_but('metadata'): - self.assertEqual(session.hooks_mode, session.HOOKS_DENY_ALL) - self.assertEqual(session.disabled_hook_categories, set()) - self.assertEqual(session.enabled_hook_categories, set(('metadata',))) + self.assertEqual(HOOKS_DENY_ALL, session.hooks_mode) + self.assertEqual(set(), session.disabled_hook_categories) + self.assertEqual(set(('metadata',)), session.enabled_hook_categories) session.commit() - self.assertEqual(session.hooks_mode, session.HOOKS_DENY_ALL) - self.assertEqual(session.disabled_hook_categories, set()) - self.assertEqual(session.enabled_hook_categories, set(('metadata',))) + self.assertEqual(HOOKS_DENY_ALL, session.hooks_mode) + self.assertEqual(set(), session.disabled_hook_categories) + self.assertEqual(set(('metadata',)), session.enabled_hook_categories) session.rollback() - self.assertEqual(session.hooks_mode, session.HOOKS_DENY_ALL) - self.assertEqual(session.disabled_hook_categories, set()) - self.assertEqual(session.enabled_hook_categories, set(('metadata',))) + self.assertEqual(HOOKS_DENY_ALL, session.hooks_mode) + self.assertEqual(set(), session.disabled_hook_categories) + self.assertEqual(set(('metadata',)), session.enabled_hook_categories) with session.allow_all_hooks_but('integrity'): - self.assertEqual(session.hooks_mode, session.HOOKS_ALLOW_ALL) - self.assertEqual(session.disabled_hook_categories, set(('integrity',))) - self.assertEqual(session.enabled_hook_categories, set(('metadata',))) # not changed in such case - self.assertEqual(session.hooks_mode, session.HOOKS_DENY_ALL) - self.assertEqual(session.disabled_hook_categories, set()) - self.assertEqual(session.enabled_hook_categories, set(('metadata',))) + self.assertEqual(HOOKS_ALLOW_ALL, session.hooks_mode) + self.assertEqual(set(('integrity',)), session.disabled_hook_categories) + self.assertEqual(set(('metadata',)), session.enabled_hook_categories) # not changed in such case + self.assertEqual(HOOKS_DENY_ALL, session.hooks_mode) + self.assertEqual(set(), session.disabled_hook_categories) + self.assertEqual(set(('metadata',)), session.enabled_hook_categories) # leaving context manager with no transaction running should reset the # transaction local storage (and associated cnxset) - self.assertEqual(session._txs, {}) - self.assertEqual(session.cnxset, None) - self.assertEqual(session.hooks_mode, session.HOOKS_ALLOW_ALL) - self.assertEqual(session.disabled_hook_categories, set()) - self.assertEqual(session.enabled_hook_categories, set()) + self.assertEqual({}, session._txs) + self.assertEqual(None, session.cnxset) + self.assertEqual(HOOKS_ALLOW_ALL, session.hooks_mode, session.HOOKS_ALLOW_ALL) + self.assertEqual(set(), session.disabled_hook_categories) + self.assertEqual(set(), session.enabled_hook_categories) if __name__ == '__main__':