# HG changeset patch # User Graziella Toutoungis # Date 1238512178 -7200 # Node ID e224f064a2680aa6fc4f11991760e1067044a091 # Parent 24486ce4dea1dbf6aae02308192593c0e7006c30 optimize this code part diff -r 24486ce4dea1 -r e224f064a268 web/views/baseviews.py --- a/web/views/baseviews.py Mon Mar 30 19:38:25 2009 -0700 +++ b/web/views/baseviews.py Tue Mar 31 17:09:38 2009 +0200 @@ -673,12 +673,8 @@ content_type = 'text/xml' http_cache_manager = MaxAgeHTTPCacheManager cache_max_age = 60*60*2 # stay in http cache for 2 hours by default - - def cell_call(self, row, col): - self.wview('rssitem', self.rset, row=row, col=col) - - def call(self): - """display a list of entities by calling their view""" + + def _open(self): req = self.req self.w(u'\n' % req.encoding) self.w(u'''%s\n' % html_escape(self.build_url(**params))) + + def _close(self): + self.w(u' \n') + self.w(u'') + + def call(self): + """display a list of entities by calling their view""" + self._open() for i in xrange(self.rset.rowcount): self.cell_call(i, 0) - self.w(u' \n') - self.w(u'') + self._close() + + def cell_call(self, row, col): + self.wview('rssitem', self.rset, row=row, col=col) class RssItemView(EntityView): id = 'rssitem' date_format = '%%Y-%%m-%%dT%%H:%%M%+03i:00' % (timezone / 3600) + add_div_section = False def cell_call(self, row, col): entity = self.complete_entity(row, col)