# HG changeset patch
# User Sylvain Thénault <sylvain.thenault@logilab.fr>
# Date 1269436367 -3600
# Node ID c9229f1856904375afa8e919c6253e73d5adba4f
# Parent  398cc8b39aecaae77c961d9ee94c2ebb289c7ee9
[notification] don't create 'changes' in transaction data until actually needed

diff -r 398cc8b39aec -r c9229f185690 hooks/notification.py
--- a/hooks/notification.py	Wed Mar 24 14:11:01 2010 +0100
+++ b/hooks/notification.py	Wed Mar 24 14:12:47 2010 +0100
@@ -112,12 +112,12 @@
         if session.added_in_transaction(self.entity.eid):
             return # entity is being created
         # then compute changes
-        changes = session.transaction_data.setdefault('changes', {})
-        thisentitychanges = changes.setdefault(self.entity.eid, set())
         attrs = [k for k in self.entity.edited_attributes
                  if not k in self.skip_attrs]
         if not attrs:
             return
+        changes = session.transaction_data.setdefault('changes', {})
+        thisentitychanges = changes.setdefault(self.entity.eid, set())
         rqlsel, rqlrestr = [], ['X eid %(x)s']
         for i, attr in enumerate(attrs):
             var = chr(65+i)