# HG changeset patch
# User Aurelien Campeas <aurelien.campeas@logilab.fr>
# Date 1306916458 -7200
# Node ID c21d845836e4cfdd127457d663d438872eb1fbd6
# Parent  5e45e32071aa614be0f195c91b90612a003a2521
[formwidgets] make the select size a class attribute (more easily tuned)

diff -r 5e45e32071aa -r c21d845836e4 web/formwidgets.py
--- a/web/formwidgets.py	Mon May 30 16:16:19 2011 +0200
+++ b/web/formwidgets.py	Wed Jun 01 10:20:58 2011 +0200
@@ -435,6 +435,7 @@
     an unicode string, or a list of unicode strings.
     """
     vocabulary_widget = True
+    default_size = 5
 
     def __init__(self, attrs=None, multiple=False, **kwargs):
         super(Select, self).__init__(attrs, **kwargs)
@@ -442,8 +443,6 @@
 
     def _render(self, form, field, renderer):
         curvalues, attrs = self.values_and_attributes(form, field)
-        if not 'size' in attrs:
-            attrs['size'] = self._multiple and '5' or '1'
         options = []
         optgroup_opened = False
         for option in field.vocabulary(form):
@@ -466,6 +465,12 @@
                 options.append(tags.option(label, value=value, **oattrs))
         if optgroup_opened:
             options.append(u'</optgroup>')
+        if not 'size' in attrs:
+            if self._multiple:
+                size = unicode(min(self.default_size, len(vocab) or 1))
+            else:
+                size = u'1'
+            attrs['size'] = size
         return tags.select(name=field.input_name(form, self.suffix),
                            multiple=self._multiple, options=options, **attrs)