# HG changeset patch
# User sylvain.thenault@logilab.fr
# Date 1236022988 -3600
# Node ID ba5257deec7d7998c3db500e6bf5183567f38ceb
# Parent  d86d1ee3b60e22e7ac7144d410cd6249ca7d2309
rename EntityRelatedTab into EntityRelationView, some fixes

diff -r d86d1ee3b60e -r ba5257deec7d web/views/tabs.py
--- a/web/views/tabs.py	Fri Feb 27 16:17:06 2009 +0100
+++ b/web/views/tabs.py	Mon Mar 02 20:43:08 2009 +0100
@@ -14,7 +14,7 @@
 from cubicweb.selectors import partial_has_related_entities
 from cubicweb.utils import HTMLHead
 from cubicweb.view import EntityView
-from cubicweb.common.uilib import rql_for_eid
+from cubicweb.common import uilib, tags
 from cubicweb.web.views.basecontrollers import JSonController
 
 
@@ -45,7 +45,7 @@
         if rql:
             urlparams['rql'] = rql
         elif eid:
-            urlparams['rql'] = rql_for_eid(eid)
+            urlparams['rql'] = uilib.rql_for_eid(eid)
         elif rset:
             urlparams['rql'] = rset.printable_rql()
         w(u'<div id="lazy-%s" cubicweb:loadurl="%s">' % (
@@ -129,9 +129,8 @@
         'cookiename' : self.cookie_name})
 
 
-class EntityRelatedTab(EntityView):
-    """A view you should inherit from leftmost,
-    to wrap another actual view displaying entity related stuff.
+class EntityRelationView(EntityView):
+    """view displaying entity related stuff.
     Such a view _must_ provide the rtype, target and vid attributes :
 
     Example :
@@ -139,18 +138,14 @@
     class ProjectScreenshotsView(EntityRelationView):
         '''display project's screenshots'''
         id = title = _('projectscreenshots')
-        accepts = ('Project',)
+        __select__ = EntityRelationView.__select__ & implements('Project')
         rtype = 'screenshot'
-        target = 'object'
+        role = 'subject'
         vid = 'gallery'
-        __selectors__ = EntityRelationView.__selectors__ + (one_line_rset,)
 
-
-    This is the view we want to have in a tab, only if there is something to show.
-    Then, just define as below, and declare this being the tab content :
-
-    class ProjectScreenshotTab(EntityRelatedTab, ProjectScreenshotsView):
-        id = 'screenshots_tab'
+    in this example, entities related to project entity by the'screenshot'
+    relation (where the project is subject of the relation) will be displayed
+    using the 'gallery' view.
     """
     __select__ = EntityView.__select__ & partial_has_related_entities()
     vid = 'list'
@@ -158,5 +153,7 @@
     def cell_call(self, row, col):
         rset = self.entity(row, col).related(self.rtype, role(self))
         self.w(u'<div class="mainInfo">')
+        if self.title:
+            self.w(tags.h1(self.req._(title)))
         self.wview(self.vid, rset, 'noresult')
         self.w(u'</div>')