# HG changeset patch
# User Sylvain Thénault <sylvain.thenault@logilab.fr>
# Date 1278074769 -7200
# Node ID af414723598dbb13146beb60efbe6aa5098057bc
# Parent  9b7c11e80d2070747a21ae0b6bac272018a83f6e
[publisher] avoid useless rollback after successful commit, which clutters debug logs and may also not be cost-free

diff -r 9b7c11e80d20 -r af414723598d web/application.py
--- a/web/application.py	Fri Jul 02 14:44:23 2010 +0200
+++ b/web/application.py	Fri Jul 02 14:46:09 2010 +0200
@@ -374,6 +374,7 @@
         # remove user callbacks on a new request (except for json controllers
         # to avoid callbacks being unregistered before they could be called)
         tstart = clock()
+        commited = False
         try:
             try:
                 ctrlid, rset = self.url_resolver.process(req, path)
@@ -391,6 +392,7 @@
                     # displaying some anonymous enabled view such as the cookie
                     # authentication form
                     req.cnx.commit()
+                    commited = True
             except (StatusResponse, DirectResponse):
                 if req.cnx:
                     req.cnx.commit()
@@ -434,7 +436,7 @@
                 self.critical('Catch all triggered!!!')
                 self.exception('this is what happened')
         finally:
-            if req.cnx:
+            if req.cnx and not commited:
                 try:
                     req.cnx.rollback()
                 except: