# HG changeset patch
# User Sylvain Thénault <sylvain.thenault@logilab.fr>
# Date 1267634539 -3600
# Node ID af2e6c377c71f70db937f7c411819c072ccd01d0
# Parent  0efdcf0fa4c75f5d575e8f69c122588b45fa42ca
cleanups

diff -r 0efdcf0fa4c7 -r af2e6c377c71 entity.py
--- a/entity.py	Wed Mar 03 17:39:22 2010 +0100
+++ b/entity.py	Wed Mar 03 17:42:19 2010 +0100
@@ -797,7 +797,7 @@
             del self.__unique
         except AttributeError:
             pass
-    
+
     # raw edition utilities ###################################################
 
     def set_attributes(self, _cw_unsafe=False, **kwargs):
diff -r 0efdcf0fa4c7 -r af2e6c377c71 schema.py
--- a/schema.py	Wed Mar 03 17:39:22 2010 +0100
+++ b/schema.py	Wed Mar 03 17:42:19 2010 +0100
@@ -50,8 +50,9 @@
     ))
 
 WORKFLOW_TYPES = set(('Transition', 'State', 'TrInfo', 'Workflow',
-                         'WorkflowTransition', 'BaseTransition',
-                         'SubWorkflowExitPoint'))
+                      'WorkflowTransition', 'BaseTransition',
+                      'SubWorkflowExitPoint'))
+
 INTERNAL_TYPES = set(('CWProperty', 'CWPermission', 'CWCache', 'ExternalUri'))
 
 
diff -r 0efdcf0fa4c7 -r af2e6c377c71 schemas/__init__.py
--- a/schemas/__init__.py	Wed Mar 03 17:39:22 2010 +0100
+++ b/schemas/__init__.py	Wed Mar 03 17:42:19 2010 +0100
@@ -1,7 +1,7 @@
 """some utilities to define schema permissions
 
 :organization: Logilab
-:copyright: 2008 LOGILAB S.A. (Paris, FRANCE), all rights reserved.
+:copyright: 2008-2010 LOGILAB S.A. (Paris, FRANCE), all rights reserved.
 :contact: http://www.logilab.fr/ -- mailto:contact@logilab.fr
 """
 __docformat__ = "restructuredtext en"
diff -r 0efdcf0fa4c7 -r af2e6c377c71 schemas/base.py
--- a/schemas/base.py	Wed Mar 03 17:39:22 2010 +0100
+++ b/schemas/base.py	Wed Mar 03 17:42:19 2010 +0100
@@ -212,6 +212,8 @@
 
     Also, checkout the AppObject.get_cache() method.
     """
+    # XXX only handle by hooks, shouldn't be readable/editable at all through
+    # the ui and so no permissions should be granted, no?
     __permissions__ = {
         'read':   ('managers', 'users', 'guests'),
         'add':    ('managers',),
diff -r 0efdcf0fa4c7 -r af2e6c377c71 server/__init__.py
--- a/server/__init__.py	Wed Mar 03 17:39:22 2010 +0100
+++ b/server/__init__.py	Wed Mar 03 17:42:19 2010 +0100
@@ -186,6 +186,7 @@
     handler.install_custom_sql_scripts(join(CW_SOFTWARE_ROOT, 'schemas'), driver)
     for directory in reversed(config.cubes_path()):
         handler.install_custom_sql_scripts(join(directory, 'schema'), driver)
+    # serialize the schema
     initialize_schema(config, schema, handler)
     # yoo !
     cnx.commit()
diff -r 0efdcf0fa4c7 -r af2e6c377c71 server/querier.py
--- a/server/querier.py	Wed Mar 03 17:39:22 2010 +0100
+++ b/server/querier.py	Wed Mar 03 17:42:19 2010 +0100
@@ -358,6 +358,7 @@
         self.preprocess(rqlst, security=False)
         return rqlst
 
+
 class InsertPlan(ExecutionPlan):
     """an execution model specific to the INSERT rql query
     """
diff -r 0efdcf0fa4c7 -r af2e6c377c71 server/session.py
--- a/server/session.py	Wed Mar 03 17:39:22 2010 +0100
+++ b/server/session.py	Wed Mar 03 17:42:19 2010 +0100
@@ -499,7 +499,7 @@
                         operation.handle_event('revert%s_event' % trstate)
                     # XXX use slice notation since self.pending_operations is a
                     # read-only property.
-                    self.pending_operations[:] = processed + self.pending_operations 
+                    self.pending_operations[:] = processed + self.pending_operations
                     self.rollback(reset_pool)
                     raise
             self.pool.commit()