# HG changeset patch # User Denis Laxalde # Date 1560431053 -7200 # Node ID a422eeca69947f1cb79155a1d1e72106d81cafd4 # Parent dfab9ef29538becce623631339b8a48a98c7d844 [config] Raise in case of failure to send emails when in test mode Since, for some reason, exception log messages are not visible when running tests, it's very hard to debug when sendmails() method fails during tests. So, as in some other places, let's raise the exception when in test mode. diff -r dfab9ef29538 -r a422eeca6994 cubicweb/cwconfig.py --- a/cubicweb/cwconfig.py Fri Jun 07 14:53:03 2019 +0200 +++ b/cubicweb/cwconfig.py Thu Jun 13 15:04:13 2019 +0200 @@ -1341,6 +1341,8 @@ except Exception as ex: self.exception("can't connect to smtp server %s:%s (%s)", server, port, ex) + if self.mode == 'test': + raise return False for msg, recipients in msgs: try: @@ -1348,6 +1350,8 @@ except Exception as ex: self.exception("error sending mail to %s (%s)", recipients, ex) + if self.mode == 'test': + raise smtp.close() finally: SMTP_LOCK.release()