# HG changeset patch
# User Sylvain Thénault <sylvain.thenault@logilab.fr>
# Date 1244628506 -7200
# Node ID 9e279029d7a08bba16f20a4477b8f38a2dca5db9
# Parent  3ea388b5b9d8e5f014c067450d3f2802594eb2d2
fix #343630 by getting explicitly TextInput widget for String, also instantiate field to get proper widget configuration

diff -r 3ea388b5b9d8 -r 9e279029d7a0 web/views/cwproperties.py
--- a/web/views/cwproperties.py	Wed Jun 10 08:21:38 2009 +0200
+++ b/web/views/cwproperties.py	Wed Jun 10 12:08:26 2009 +0200
@@ -19,7 +19,7 @@
 from cubicweb.web import uicfg, stdmsgs
 from cubicweb.web.form import FormViewMixIn
 from cubicweb.web.formfields import FIELDS, StringField
-from cubicweb.web.formwidgets import Select, Button, SubmitButton
+from cubicweb.web.formwidgets import Select, TextInput, Button, SubmitButton
 from cubicweb.web.views import primary, formrenderers
 
 
@@ -346,12 +346,13 @@
             else:
                 self.choices = vocab
             wdg = Select()
+        elif pdef['type'] == 'String': # else we'll get a TextArea by default
+            wdg = TextInput()
         else:
-            wdg = FIELDS[pdef['type']].widget()
+            field = FIELDS[pdef['type']]()
+            wdg = field.widget
             if pdef['type'] == 'Boolean':
-                self.choices = [(form.req._('yes'), '1'), (form.req._('no'), '')]
-            elif pdef['type'] in ('Float', 'Int'):
-                wdg.attrs.setdefault('size', 3)
+                self.choices = field.vocabulary(form)
         self.widget = wdg