# HG changeset patch
# User Aurelien Campeas <aurelien.campeas@logilab.fr>
# Date 1256055216 -7200
# Node ID 9d93faa0e6dc01ad46751dd71a185c571409a6f5
# Parent  e68b8e0143b126b337a48801cb5fe8caa7fd26a0
actually hide the value when editing, cleanup spurious arg

diff -r e68b8e0143b1 -r 9d93faa0e6dc web/data/cubicweb.edition.js
--- a/web/data/cubicweb.edition.js	Tue Oct 20 17:13:05 2009 +0200
+++ b/web/data/cubicweb.edition.js	Tue Oct 20 18:13:36 2009 +0200
@@ -493,7 +493,7 @@
 
 
 /**** inline edition ****/
-function loadInlineEditionForm(eid, rtype, role, eid, divid, reload, vid,
+function loadInlineEditionForm(eid, rtype, role, divid, reload, vid,
                                default_value, lzone) {
   var args = {fname: 'reledit_form', rtype: rtype, role: role, eid: eid, divid: divid,
               reload: reload, vid: vid, default_value: default_value, landing_zone: lzone,
diff -r e68b8e0143b1 -r 9d93faa0e6dc web/views/editforms.py
--- a/web/views/editforms.py	Tue Oct 20 17:13:05 2009 +0200
+++ b/web/views/editforms.py	Tue Oct 20 18:13:36 2009 +0200
@@ -194,14 +194,15 @@
         """xxx-reledit div (class=field)
               +-xxx div (class="editableField")
               |   +-landing zone
-              +-value
+              +   +-value
               +-form-xxx div
         """
         w = self.w
         w(u'<div id="%s-reledit" class="field">' % form.event_args['divid'])
-        w(tags.div(lzone, klass='editableField', id=form.event_args['divid'],
-                   onclick=self._onclick % form.event_args))
+        w(u'<div id="%s" class="editableField" onclick="%s">%s' % (
+                form.event_args['divid'], xml_escape(self._onclick % form.event_args), lzone))
         w(value)
+        w(u'</div>')
         w(form.form_render(renderer=renderer))
         w(u'</div>')
 
@@ -256,7 +257,7 @@
     by checking uicfg configuration and composite relation property.
     """
     id = 'reledit'
-    _onclick = (u"loadInlineEditionForm(%(eid)s, '%(rtype)s', '%(role)s', '%(eid)s', "
+    _onclick = (u"loadInlineEditionForm(%(eid)s, '%(rtype)s', '%(role)s', "
                 "'%(divid)s', %(reload)s, '%(vid)s', '%(default)s', '%(lzone)s');")
 
     def should_edit_attribute(self, entity, rschema, role, _form):