# HG changeset patch # User Aurelien Campeas # Date 1388683831 -3600 # Node ID 8e87f1e18a37edb2c71519e48b12bbbe3fff0824 # Parent d7e8293fa4de7e80269e4bb99898e807c89816cb [views/workflow/tmppng] fix console crash on nth call to this one-shot view The underlying design issue is not addressed here, only a cosmetic and "we understand and document what's happening" note. Related to #3400448. diff -r d7e8293fa4de -r 8e87f1e18a37 web/views/workflow.py --- a/web/views/workflow.py Tue Dec 10 11:44:06 2013 +0000 +++ b/web/views/workflow.py Thu Jan 02 18:30:31 2014 +0100 @@ -442,6 +442,13 @@ binary = True def cell_call(self, row=0, col=0): - tmpfile = self._cw.session.data[self._cw.form['tmpfile']] + key = self._cw.form['tmpfile'] + if key not in self._cw.session.data: + # the temp file is gone and there's nothing + # we can do about it + # we should probably write it to some well + # behaved place and serve it + return + tmpfile = self._cw.session.data.pop(key) self.w(open(tmpfile, 'rb').read()) os.unlink(tmpfile)