# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@logilab.fr>
# Date 1372087573 -7200
# Node ID 8c0016d7a0919943c3da362bceb2f6ae11c69618
# Parent  795ea498225f5d52598968bd31a87084d321f6dc
[client-connection] add an auto-close property for ClientConnection

The next commit introduce a connect function that open a new Session and return
an associated ClientConnection. The Session should not be used by anything else
than the created ClientConnection, so we want to close it at the same time than
the ClientConnection. The implementation in this changeset is simplistic. We
probably want to move this notion in the session itself. This be improved  once
we have server side Connection

diff -r 795ea498225f -r 8c0016d7a091 repoapi.py
--- a/repoapi.py	Fri Jun 21 12:08:06 2013 +0200
+++ b/repoapi.py	Mon Jun 24 17:26:13 2013 +0200
@@ -94,6 +94,10 @@
     This object is aimed to be used client side (so potential communication
     with the repo through RTC) and aims to offer some compatibility with the
     cubicweb.dbapi.Connection interface.
+
+    The autoclose_session paramenter informs the connection that this session
+    have been open explictly and only for this client connection. The
+    connection will close the session of exit.
     """
     # make exceptions available through the connection object
     ProgrammingError = ProgrammingError
@@ -101,13 +105,14 @@
     anonymous_connection = False # XXX really needed ?
     is_repo_in_memory = True # BC, always true
 
-    def __init__(self, session):
+    def __init__(self, session, autoclose_session=False):
         self._session = session
         self._cnxid = None
         self._open = None
         self._web_request = False
         self.vreg = session.vreg
         self._set_user(session.user)
+        self._autoclose_session = autoclose_session
 
     def __enter__(self):
         assert self._open is None
@@ -122,6 +127,10 @@
         self._cnxid = None
         self._session._cnx.ctx_count -= 1
         self._session.close_cnx(cnxid)
+        if self._autoclose_session:
+            # we have to call repo.close to unsure the repo properly forget the
+            # session calling session.close() is not enought :-(
+            self._session.repo.close(self._session.id)
 
 
     # begin silly BC