# HG changeset patch # User pierre-yves # Date 1369662483 -7200 # Node ID 81a5d57d9230f704adaeeb6fc0aa30ae7b485b5b # Parent 4f45968cd956f66aa992c13b7cc39fa9e94899c0 [session] upgrade session closed error from Exception to SessionClosedError Exception is far too wide and we already have a SessionClosedError anyway. Closes #2897696 diff -r 4f45968cd956 -r 81a5d57d9230 server/session.py --- a/server/session.py Thu Jun 06 12:29:44 2013 +0200 +++ b/server/session.py Mon May 27 15:48:03 2013 +0200 @@ -1110,7 +1110,7 @@ """connections set, set according to transaction mode for each query""" if self._closed: self.free_cnxset(True) - raise Exception('try to access connections set on a closed session %s' % self.id) + raise SessionClosedError('try to access connections set on a closed session %s' % self.id) return self._tx.cnxset def set_cnxset(self): @@ -1118,7 +1118,7 @@ with self._lock: # can probably be removed if self._closed: self.free_cnxset(True) - raise Exception('try to set connections set on a closed session %s' % self.id) + raise SessionClosedError('try to set connections set on a closed session %s' % self.id) return self._tx.set_cnxset() free_cnxset = tx_meth('free_cnxset') diff -r 4f45968cd956 -r 81a5d57d9230 server/test/unittest_repository.py --- a/server/test/unittest_repository.py Thu Jun 06 12:29:44 2013 +0200 +++ b/server/test/unittest_repository.py Mon May 27 15:48:03 2013 +0200 @@ -44,6 +44,7 @@ from cubicweb.server.sqlutils import SQL_PREFIX from cubicweb.server.hook import Hook from cubicweb.server.sources import native +from cubicweb.server.session import SessionClosedError class RepositoryTC(CubicWebTC): @@ -262,7 +263,7 @@ repo.execute(cnxid, 'DELETE CWUser X WHERE X login "toto"') repo.commit(cnxid) try: - with self.assertRaises(Exception) as cm: + with self.assertRaises(SessionClosedError) as cm: run_transaction() self.assertEqual(str(cm.exception), 'try to access connections set on a closed session %s' % cnxid) finally: