# HG changeset patch # User Sylvain Thénault # Date 1264167614 -3600 # Node ID 7add8a73a16811977f78ea107d87f304801a97dd # Parent cb7b686795011bb374028b38b13a345c98b37ba9 [vreg] object_by_id should not have been deprecated. Fix facets. it was *designed* to be able to force an object retreival when selection is potentially not possible. For instance using select instead of object_by_id in get_facet totally breaks the implementation since in get_facet we've not context result set, and we ends up with a NoSelectableObject exception. diff -r cb7b68679501 -r 7add8a73a168 vregistry.py --- a/vregistry.py Fri Jan 22 11:40:22 2010 +0100 +++ b/vregistry.py Fri Jan 22 14:40:14 2010 +0100 @@ -139,7 +139,6 @@ # dynamic selection methods ################################################ - @deprecated('[3.6] use select instead of object_by_id') def object_by_id(self, oid, *args, **kwargs): """return object with the given oid. Only one object is expected to be found. diff -r cb7b68679501 -r 7add8a73a168 web/facet.py --- a/web/facet.py Fri Jan 22 11:40:22 2010 +0100 +++ b/web/facet.py Fri Jan 22 14:40:14 2010 +0100 @@ -64,8 +64,8 @@ def get_facet(req, facetid, rqlst, mainvar): - return req.vreg['facets'].select(facetid, req, rqlst=rqlst, - filtered_variable=mainvar) + return req.vreg['facets'].object_by_id(facetid, req, rqlst=rqlst, + filtered_variable=mainvar) def filter_hiddens(w, **kwargs):