# HG changeset patch
# User sylvain.thenault@logilab.fr
# Date 1239888936 -7200
# Node ID 6c6dbc0df829f9ce0c369f5ade580e9eadc37aeb
# Parent  3645800647ef8cb771a146d81d2228b96eb0c885
MUST NOT consider req.form['rql'] in a view, use len(rset) > 1 to detect if we can apply tabs or not

diff -r 3645800647ef -r 6c6dbc0df829 web/views/tabs.py
--- a/web/views/tabs.py	Wed Apr 15 16:42:00 2009 -0700
+++ b/web/views/tabs.py	Thu Apr 16 15:35:36 2009 +0200
@@ -96,19 +96,25 @@
         return selected_tabs
 
     def render_tabs(self, tabs, default, entity):
+        # tabbed views do no support concatenation
+        # hence we delegate to the default tab if there is more than on entity
+        # in the result set
+        if len(self.rset) > 1:
+            entity.view(default, w=self.w)
+            return
+        # XXX (syt) fix below add been introduced at some point to fix something
+        # (http://intranet.logilab.fr/jpl/ticket/32174 ?) but this is not a clean
+        # way. We must not consider form['rql'] here since it introduces some
+        # other failures on non rql queries (plain text, shortcuts,... handled by
+        # magicsearch) which has a single result whose primary view is using tabs
+        # (https://www.logilab.net/cwo/ticket/342789)
+        #rql = self.req.form.get('rql')
+        #if rql:
+        #    self.req.execute(rql).get_entity(0,0).view(default, w=self.w)
+        #    return
         self.req.add_css('ui.tabs.css')
         self.req.add_js(('ui.core.js', 'ui.tabs.js',
                          'cubicweb.ajax.js', 'cubicweb.tabs.js', 'cubicweb.lazy.js'))
-        # tabbed views do no support concatenation
-        # hence we delegate to the default tab
-        form = self.req.form
-        if form.get('vid') == 'primary':
-            entity.view(default, w=self.w)
-            return
-        rql = form.get('rql')
-        if rql:
-            self.req.execute(rql).get_entity(0,0).view(default, w=self.w)
-            return
         # prune tabs : not all are to be shown
         tabs = self.prune_tabs(tabs)
         # select a tab