# HG changeset patch
# User Alain Leufroy <alain.leufroy@logilab.fr>
# Date 1401717189 -7200
# Node ID 62c586f32f9385da844361699e435b6efd2730e2
# Parent  161ec913aeecd3ea114bef2fbb0587f398190d75
[dataimport] _create_copyfrom_buffer: do not ignore columns if data is a list

Related to #3845572

diff -r 161ec913aeec -r 62c586f32f93 dataimport.py
--- a/dataimport.py	Mon Jun 02 17:52:43 2014 +0200
+++ b/dataimport.py	Mon Jun 02 15:53:09 2014 +0200
@@ -487,7 +487,7 @@
     (time, _copyfrom_buffer_convert_time),
 ]
 
-def _create_copyfrom_buffer(data, columns, **convert_opts):
+def _create_copyfrom_buffer(data, columns=None, **convert_opts):
     """
     Create a StringIO buffer for 'COPY FROM' command.
     Deals with Unicode, Int, Float, Date... (see ``converters``)
@@ -499,8 +499,13 @@
     # Create a list rather than directly create a StringIO
     # to correctly write lines separated by '\n' in a single step
     rows = []
-    if isinstance(data[0], (tuple, list)):
-        columns = range(len(data[0]))
+    if columns is None:
+        if isinstance(data[0], (tuple, list)):
+            columns = range(len(data[0]))
+        elif isinstance(data[0], dict):
+            columns = data[0].keys()
+        else:
+            raise ValueError('Could not get columns: you must provide columns.')
     for row in data:
         # Iterate over the different columns and the different values
         # and try to convert them to a correct datatype.