# HG changeset patch # User Aurelien Campeas # Date 1426604152 -3600 # Node ID 5dc6dc2c0de920e8b2bef6e0b4a7372bc450bfc1 # Parent f738180d499d6a29170cef8b28c35b1e22650aab [dbapi] retire repo.commit/rollback which was used by the dbapi Related to #3933480. diff -r f738180d499d -r 5dc6dc2c0de9 server/repository.py --- a/server/repository.py Tue Mar 17 15:46:40 2015 +0100 +++ b/server/repository.py Tue Mar 17 15:55:52 2015 +0100 @@ -694,30 +694,6 @@ session = self._get_session(sessionid, setcnxset=False) session.set_shared_data(key, value, txdata) - def commit(self, sessionid, txid=None): - """commit transaction for the session with the given id""" - self.debug('begin commit for session %s', sessionid) - try: - session = self._get_session(sessionid) - session.set_cnx(txid) - return session.commit() - except (ValidationError, Unauthorized): - raise - except Exception: - self.exception('unexpected error') - raise - - def rollback(self, sessionid, txid=None): - """commit transaction for the session with the given id""" - self.debug('begin rollback for session %s', sessionid) - try: - session = self._get_session(sessionid) - session.set_cnx(txid) - session.rollback() - except Exception: - self.exception('unexpected error') - raise - def close(self, sessionid, txid=None, checkshuttingdown=True): """close the session with the given id""" session = self._get_session(sessionid, txid=txid, diff -r f738180d499d -r 5dc6dc2c0de9 server/test/unittest_repository.py --- a/server/test/unittest_repository.py Tue Mar 17 15:46:40 2015 +0100 +++ b/server/test/unittest_repository.py Tue Mar 17 15:55:52 2015 +0100 @@ -491,7 +491,6 @@ self.assertEqual(tuplify(data), [(-1, 'Personne', 'system', None)]) self.repo._delete_cascade_multi(cnx, [entity]) self.repo.system_source.delete_info_multi(cnx, [entity]) - #self.repo.commit() cu = cnx.system_sql('SELECT * FROM entities WHERE eid = -1') data = cu.fetchall() self.assertEqual(data, [])